XoopsModules25x/apcal

View on GitHub

Showing 26,336 of 26,336 total issues

Function parseStandardTemplate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        public function parseStandardTemplate($name, $mode = 'w')
        {
            $name = strtoupper($name);

            //  get a copy of the plain content
Severity: Minor
Found in include/patTemplate.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                } else if (/highslide-image-blur/.test(el.className)) {
                    el.style.cursor = hs.styleRestoreCursor;
                }
Severity: Major
Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if (!hiddenBy) els[i].style[prop] = els[i].origProp;
    Severity: Major
    Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  for ($k = 0, $kMax = count($matches[0]); $k <= $kMax; ++$k) {
                                      if ($matches[1][$k] !== '' && !isset($this->variables[$name][$matches[1][$k]])
                                          && !isset($this->globals[$matches[1][$k]])
                                      ) {
                                          $unused[] = $matches[0][$k];
      Severity: Major
      Found in include/patTemplate.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if ($matches[1][$k] !== '' && !isset($this->variables[$name][$matches[1][$k]])
                                        && !isset($this->globals[$matches[1][$k]])
                                    ) {
                                        $unused[] = $matches[0][$k];
                                    }
        Severity: Major
        Found in include/patTemplate.php - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if (!hasDragged && !hs.hasFocused && !/(move|resize)/.test(hs.dragArgs.type)) {
                                  exp.close();
                              }
                              else if (hasDragged || (!hasDragged && hs.hasHtmlExpanders)) {
                                  hs.dragArgs.exp.doShowHide('hidden');
          Severity: Major
          Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

            Function endElementHandler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                    public function endElementHandler($fname, $tagname, $line)
                    {
                        array_pop($this->whitespace);
            
                        switch ($tagname) {
            Severity: Minor
            Found in include/patTemplate.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                if (!$startmod_updated && $new_value != '--' && $config->getVar('conf_catid') == XOOPS_CONF
                                    && $config->getVar('conf_name') === 'startpage'
                                ) {
                                    $memberHandler     = xoops_getHandler('member');
                                    $groups             = $memberHandler->getGroupList();
            Severity: Major
            Found in include/preferences.inc.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if (hs.dragArgs.exp.releaseMask)
                                      hs.dragArgs.exp.releaseMask.style.display = 'none';
              Severity: Major
              Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                if ($cal->ro_extrainfo2 !== '') {
                                    $retList .= "<td class='$classname'>$romextrainfo2</td>";
                                }
                Severity: Major
                Found in ro_regonlinehandler.php - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                  if ($cal->ro_extrainfo4 !== '') {
                                      $retList .= "<td class='$classname'>$romextrainfo4</td>";
                                  }
                  Severity: Major
                  Found in ro_regonlinehandler.php - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                    if ($counter > 4) {
                                        $counter = 0;
                                        echo '</tr>';
                                        echo '<tr>';
                                    }
                    Severity: Major
                    Found in admin/admin.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          if (!$theme_updated && $config->getVar('conf_catid') == XOOPS_CONF
                                              && $config->getVar('conf_name') === 'theme_set'
                                          ) {
                                              $memberHandler = xoops_getHandler('member');
                                              $memberHandler->updateUsersByField('theme', $_POST[$config->getVar('conf_name')]);
                      Severity: Major
                      Found in include/preferences.inc.php - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                        if ($cal->ro_extrainfo1 !== '') {
                                            $retList .= "<td class='$classname'>$romextrainfo1</td>";
                                        }
                        Severity: Major
                        Found in ro_regonlinehandler.php - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                              } else if (visibility == 'hidden') { // hide if behind
                                                  var elPos = hs.getPosition(els[i]);
                                                  elPos.w = els[i].offsetWidth;
                                                  elPos.h = els[i].offsetHeight;
                          
                          
                          Severity: Major
                          Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    for (var key = 0; key < hs.expanders.length; key++) {
                                                        var exp = hs.expanders[key];
                                                        if (exp && exp.a == el) return key;
                                                    }
                            Severity: Major
                            Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                              if ($cal->ro_extrainfo3 !== '') {
                                                  $retList .= "<td class='$classname'>$romextrainfo3</td>";
                                              }
                              Severity: Major
                              Found in ro_regonlinehandler.php - About 45 mins to fix

                                Function parseIterativeTemplate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                Open

                                        public function parseIterativeTemplate($name, $mode)
                                        {
                                            $name = strtoupper($name);
                                
                                            $temp = '';
                                Severity: Minor
                                Found in include/patTemplate.php - About 45 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Avoid deeply nested control flow statements.
                                Open

                                                    for ($j = 0, $jMax = count($old_vals); $j < $jMax; ++$j) {
                                                        $def_vals[$j] = $old_vals[$j];
                                                    }
                                Severity: Major
                                Found in include/updateblock.inc.php - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                  if ($cal->ro_extrainfo5 !== '') {
                                                      $retList .= "<td class='$classname'>$romextrainfo5</td>";
                                                  }
                                  Severity: Major
                                  Found in ro_regonlinehandler.php - About 45 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language