Sign upLogin

XoopsModules25x/apcal

View on GitHub
Star

Showing 26,336 of 26,336 total issues

Function css has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        css: function (el, prop) {
            if (el.style[prop]) {
                return el.style[prop];
            } else if (document.defaultView) {
                return document.defaultView.getComputedStyle(el, null).getPropertyValue(prop);
Severity: Minor
Found in assets/images/js/highslide/highslide.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function destroyOverlays has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        destroyOverlays: function () {
            if (!this.overlays.length) return;
            if (this.slideshow) {
                var c = this.slideshow.controls;
                if (c && hs.getExpander(c) == this) c.parentNode.removeChild(c);
Severity: Minor
Found in assets/images/js/highslide/highslide-with-gallery.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        get: function (key) {
            switch (key) {
                case 'loadingPos':
                    return this.tpos + this.tb + (this.t - hs.loading['offset' + this.ucwh]) / 2;
                case 'loadingPosXfade':
Severity: Minor
Found in assets/images/js/highslide/highslide-with-gallery.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setSize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        setSize: function (i) {
            var exp = this.exp;
            if (exp.isImage && (exp.useBox || hs.padToMinWidth)) {
                this.imgSize = i;
                this.size = Math.max(this.size, this.imgSize);
Severity: Minor
Found in assets/images/js/highslide/highslide-with-gallery.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function issue has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        public function issue($salt = '', $timeout = 1800, $area = '')
        {
            global $xoopsModule;
            if ('' === $salt) {
                if (function_exists('mcrypt_create_iv') && !defined('PHALANGER')) {
Severity: Minor
Found in include/gtickets.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function xoops_module_install_apcal has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function xoops_module_install_apcal(XoopsModule $xoopsModule)
{
    require_once  __DIR__ . '/../../../mainfile.php';
    require_once  __DIR__ . '/../include/config.php';
Severity: Minor
Found in include/oninstall.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Contrast has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function Contrast(&$gdimg, $amount = 0)
    {
        if ($amount == 0) {
            return true;
        }
Severity: Minor
Found in thumbs/phpthumb.filters.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Flip has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function Flip(&$gdimg, $x = false, $y = false)
    {
        if (!$x && !$y) {
            return false;
        }
Severity: Minor
Found in thumbs/phpthumb.filters.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function selectThumb has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        function selectThumb(i, scrollBy) {
            if (i === undefined) for (var j = 0; j < group.length; j++) {
                if (group[j] == hs.expanders[slideshow.expKey].a) {
                    i = j;
                    break;
Severity: Minor
Found in assets/images/js/highslide/highslide-with-gallery.js - About 1 hr to fix

    Function selectThumb has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function selectThumb(i, scrollBy) {
            if (i === undefined) for (var j = 0; j < group.length; j++) {
                if (group[j] == hs.expanders[slideshow.expKey].a) {
                    i = j;
                    break;
    Severity: Minor
    Found in assets/images/js/highslide/highslide-full.js - About 1 hr to fix

      Method getTemplateContent has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public function getTemplateContent($name)
        {
            $name  = strtoupper($name);
            $index = $this->iteration[$name];
      Severity: Minor
      Found in include/patTemplate.php - About 1 hr to fix

        Method PlotPixelsGD has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function PlotPixelsGD(&$BMPdata, $truecolor = true)
    {
        $imagewidth  = $BMPdata['header']['raw']['width'];
        $imageheight = $BMPdata['header']['raw']['height'];
        Severity: Minor
        Found in thumbs/phpthumb.bmp.php - About 1 hr to fix

          Method getGD_PixelPlotterVersion has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getGD_PixelPlotterVersion()
    {
        if (!$this->m_bLoaded) {
            return false;
        }
          Severity: Minor
          Found in thumbs/phpthumb.gif.php - About 1 hr to fix

            Method Sepia has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function Sepia(&$gdimg, $amount, $targetColor)
    {
        $amount      = (is_numeric($amount) ? max(0, min(100, $amount)) : 50);
        $amountPct   = $amount / 100;
        $targetColor = (phpthumb_functions::IsHexColor($targetColor) ? $targetColor : 'A28065');
            Severity: Minor
            Found in thumbs/phpthumb.filters.php - About 1 hr to fix

              Method Colorize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function Colorize(&$gdimg, $amount, $targetColor)
    {
        $amount      = (is_numeric($amount) ? $amount : 25);
        $amountPct   = $amount / 100;
        $targetColor = (phpthumb_functions::IsHexColor($targetColor) ? $targetColor : 'gray');
              Severity: Minor
              Found in thumbs/phpthumb.filters.php - About 1 hr to fix

                Identical blocks of code found in 4 locations. Consider refactoring.
                Open

                        error: function (e) {
            if (hs.debug) alert('Line ' + e.lineNumber + ': ' + e.message);
            else window.location.href = this.src;
        },
                Severity: Major
                Found in assets/images/js/highslide/highslide.js and 3 other locations - About 1 hr to fix
                assets/images/js/highslide/highslide-full.js on lines 1462..1465
                assets/images/js/highslide/highslide-with-gallery.js on lines 1265..1268
                assets/images/js/highslide/highslide-with-html.js on lines 1257..1260

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 4 locations. Consider refactoring.
                Open

                        error: function (e) {
            if (hs.debug) alert('Line ' + e.lineNumber + ': ' + e.message);
            else window.location.href = this.src;
        },
                Severity: Major
                Found in assets/images/js/highslide/highslide-with-html.js and 3 other locations - About 1 hr to fix
                assets/images/js/highslide/highslide-full.js on lines 1462..1465
                assets/images/js/highslide/highslide-with-gallery.js on lines 1265..1268
                assets/images/js/highslide/highslide.js on lines 1076..1079

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 4 locations. Consider refactoring.
                Open

                        error: function (e) {
            if (hs.debug) alert('Line ' + e.lineNumber + ': ' + e.message);
            else window.location.href = this.src;
        },
                Severity: Major
                Found in assets/images/js/highslide/highslide-full.js and 3 other locations - About 1 hr to fix
                assets/images/js/highslide/highslide-with-gallery.js on lines 1265..1268
                assets/images/js/highslide/highslide-with-html.js on lines 1257..1260
                assets/images/js/highslide/highslide.js on lines 1076..1079

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 4 locations. Consider refactoring.
                Open

                        error: function (e) {
            if (hs.debug) alert('Line ' + e.lineNumber + ': ' + e.message);
            else window.location.href = this.src;
        },
                Severity: Major
                Found in assets/images/js/highslide/highslide-with-gallery.js and 3 other locations - About 1 hr to fix
                assets/images/js/highslide/highslide-full.js on lines 1462..1465
                assets/images/js/highslide/highslide-with-html.js on lines 1257..1260
                assets/images/js/highslide/highslide.js on lines 1076..1079

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function fade has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        fade: function (up, to) {
            this.outlineWhileAnimating = false;
            var exp = this, t = up ? hs.expandDuration : 0;

            if (up) {
                Severity: Minor
                Found in assets/images/js/highslide/highslide-full.js - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language