XoopsModules25x/apcal

View on GitHub

Showing 26,336 of 26,336 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        case 37: // KEY left
                            if (--x >= 0)
                                ne = cal.ar_days[y][x];
                            else {
                                x = 6;
Severity: Major
Found in assets/js/jscalendar/calendar.js and 1 other location - About 1 hr to fix
assets/js/jscalendar/calendar.js on lines 1040..1048

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            hs.setStyles(content, {
                width: (x.imgSize || x.size) + 'px',
                height: (y.imgSize || y.size) + 'px'
            });
Severity: Major
Found in assets/images/js/highslide/highslide-full.js and 1 other location - About 1 hr to fix
assets/images/js/highslide/highslide-with-gallery.js on lines 1682..1685

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            hs.setStyles(content, {
                width: (x.imgSize || x.size) + 'px',
                height: (y.imgSize || y.size) + 'px'
            });
Severity: Major
Found in assets/images/js/highslide/highslide-with-gallery.js and 1 other location - About 1 hr to fix
assets/images/js/highslide/highslide-full.js on lines 2165..2168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        case 39: // KEY right
                            if (++x < 7)
                                ne = cal.ar_days[y][x];
                            else {
                                x = 0;
Severity: Major
Found in assets/js/jscalendar/calendar.js and 1 other location - About 1 hr to fix
assets/js/jscalendar/calendar.js on lines 1023..1031

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class DHTML_Calendar

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

    class Dummy
Severity: Minor
Found in admin/categories.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class MyXoopsGroupFormCheckBox extends XoopsFormElement
Severity: Minor
Found in admin/mygrouppermform.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class MyXoopsGroupPermForm extends XoopsForm
Severity: Minor
Found in admin/mygrouppermform.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff_Op_add extends Text_Diff_Op
Severity: Minor
Found in include/Text_Diff.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff
Severity: Minor
Found in include/Text_Diff.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff_Engine_native
Severity: Minor
Found in include/Text_Diff.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class ModuleConfigurator
Severity: Minor
Found in include/config.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

    class PatTemplate
Severity: Minor
Found in include/patTemplate.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff_Op_copy extends Text_Diff_Op
Severity: Minor
Found in include/Text_Diff.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff_Renderer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff_Renderer_inline extends Text_Diff_Renderer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff_Engine_xdiff
Severity: Minor
Found in include/Text_Diff.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff_Op_delete extends Text_Diff_Op
Severity: Minor
Found in include/Text_Diff.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff_Op_change extends Text_Diff_Op
Severity: Minor
Found in include/Text_Diff.php by phpcodesniffer

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Text_Diff_Renderer_unified extends Text_Diff_Renderer
Severity
Category
Status
Source
Language