Showing 370 of 370 total issues
Method Output has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
function Output($name='',$dest='')
{
//Output PDF to some destination
//Finish document if necessary
if($this->state<3)Method check has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function check($post = true, $area = '', $allow_repost = true)
{
global $xoopsModule;
$this->_errors = array();Method OpenTag has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
function OpenTag($tag,$attr,$scale)
{
//Opening tag
switch($tag){
case 'STRONG':Method b_system_comments_show has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_comments_show($options)
{
$block = array();
include_once XOOPS_ROOT_PATH . '/include/comment_constants.php';
$commentHandler = xoops_getHandler('comment');File addto-multi.js has 253 lines of code (exceeds 250 allowed). Consider refactoring. Open
// <license>
// Script: Add To Bookmarks
// Version: 1.1
// Homepage: http://www.AddToBookmarks.com/
// Author: Gideon MarkenMethod AddPage has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
function AddPage($orientation='')
{
//Start a new page
if($this->state==0)
$this->Open();Method delCat has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
function delCat()
{
global $xoopsDB, $myCatTree, $xoopsModule, $xoopsUser;
$cid = MylinksUtility::mylinks_cleanVars($_REQUEST, 'cid', 0, 'int', array('min' => 0));File gtickets.php has 251 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
// GIJOE's Ticket Class (based on Marijuana's Oreteki XOOPS)
// nobunobu's suggestions are applied
if (!class_exists('XoopsGTicket')) {Method listBrokenLinks has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
function listBrokenLinks()
{
global $xoopsDB, $xoopsModule, $pathIcon16, $myts;
$result = $xoopsDB->query('SELECT * FROM ' . $xoopsDB->prefix('mylinks_broken') . ' GROUP BY lid ORDER BY reportid DESC');Method SetFont has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
function SetFont($family,$style='',$size=0)
{
//Select a font; size given in points
global $fpdf_charwidths;
Method b_system_info_show has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_info_show($options)
{
global $xoopsConfig, $xoopsUser;
$xoopsDB = XoopsDatabaseFactory::getDatabaseConnection();
$myts = MyTextSanitizer::getInstance();Method linksConfigMenu has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
function linksConfigMenu()
{
global $xoopsDB, $myts, $myCatTree, $xoopsModule;
$mylinksCatHandler = xoops_getModuleHandler('category', $xoopsModule->getVar('dirname'));Method render has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function render()
{
global $xoopsGTicket;
// load all child ids for javascript codesSimilar blocks of code found in 2 locations. Consider refactoring. Open
function ignoreBrokenLinks()
{
global $xoopsDB;
$bknrptid = MylinksUtility::mylinks_cleanVars($_POST, 'bknrptid', 0, 'int', array('min' => 0));- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 120.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
function ignoreModReq()
{
global $xoopsDB;
$requestid = MylinksUtility::mylinks_cleanVars($_POST, 'requestid', 0, 'int', array('min' => 0));- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 120.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function b_system_online_show has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
function b_system_online_show()
{
global $xoopsUser, $xoopsModule;
$onlineHandler = xoops_getHandler('online');
mt_srand((double)microtime() * 1000000);- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function listBrokenLinks has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
function listBrokenLinks()
{
global $xoopsDB, $xoopsModule, $pathIcon16, $myts;
$result = $xoopsDB->query('SELECT * FROM ' . $xoopsDB->prefix('mylinks_broken') . ' GROUP BY lid ORDER BY reportid DESC');- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function xoops_module_pre_install_mylinks_base has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
function xoops_module_pre_install_mylinks_base(&$xoopsModule)
{
global $xoopsDB;
$retVal = true;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method b_system_online_show has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_online_show()
{
global $xoopsUser, $xoopsModule;
$onlineHandler = xoops_getHandler('online');
mt_srand((double)microtime() * 1000000);Method PutImage has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
function PutImage($url,$scale)
{
if($scale<0) $scale=0;
//$scale<=0: put NO image inside the pdf!
if($scale>0){