Sign upLogin

XoopsModules25x/mylinks

View on GitHub
Star

Showing 370 of 370 total issues

Method GoogleCH has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function GoogleCH($url, $length = null, $init = GOOGLE_MAGIC)
{
    if (null === $length) {
        $length = count($url);
    }
Severity: Minor
Found in bookmark.php - About 1 hr to fix

    Method _parsegif has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function _parsegif($file)
  {
    require_once 'gif.php'; //GIF class in pure PHP from Yamasoft (http://www.yamasoft.com/php-gif.zip)

    $h=0;
    Severity: Minor
    Found in fpdf/makepdf_class.php - About 1 hr to fix

      Method render has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function render($diff)
    {
        $xi      = $yi = 1;
        $block   = false;
        $context = array();
      Severity: Minor
      Found in class/Text_Diff_Renderer.php - About 1 hr to fix

        Function _parsegif has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          function _parsegif($file)
  {
    require_once 'gif.php'; //GIF class in pure PHP from Yamasoft (http://www.yamasoft.com/php-gif.zip)

    $h=0;
        Severity: Minor
        Found in fpdf/makepdf_class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function GetCode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          function GetCode(&$data, $bInit)
  {
    if($bInit) {
      $this->CurBit   = 0;
      $this->LastBit  = 0;
        Severity: Minor
        Found in fpdf/gif.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function OpenTag has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          function OpenTag($tag,$attr,$scale)
  {
      //Opening tag
      switch($tag){
          case 'STRONG':
        Severity: Minor
        Found in fpdf/makepdf_class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _compareseq has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function _compareseq($xoff, $xlim, $yoff, $ylim)
    {
        /* Slide down the bottom initial diagonal. */
        while ($xoff < $xlim && $yoff < $ylim && $this->xv[$xoff] == $this->yv[$yoff]) {
            ++$xoff;
        Severity: Minor
        Found in class/Text_Diff.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _putimages has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function _putimages()
{
  $filter= $this->compress ? '/Filter /FlateDecode ' : '';
  reset($this->images);
  while(list($file,$info)=each($this->images))
        Severity: Minor
        Found in fpdf/fpdf.php - About 1 hr to fix

          Method mylinks_notify_iteminfo has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function mylinks_notify_iteminfo($category, $item_id)
{
    global $xoopsModule, $xoopsModuleConfig, $xoopsConfig, $xoopsDB;
    $dirname = basename(dirname(__DIR__));
          Severity: Minor
          Found in include/notification.inc.php - About 1 hr to fix

            Method Image has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function Image($file,$x,$y,$w=0,$h=0,$type='',$link='')
{
  //Put an image on the page
  if(!isset($this->images[$file]))
  {
            Severity: Minor
            Found in fpdf/fpdf.php - About 1 hr to fix

              Method AddFont has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function AddFont($family,$style='',$file='')
{
  //Add a TrueType or Type1 font
  $family=strtolower($family);
  if($file=='')
              Severity: Minor
              Found in fpdf/fpdf.php - About 1 hr to fix

                Method xoops_module_update_mylinks_base has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function xoops_module_update_mylinks_base(XoopsModule $xoopsModule, $prev_version)
{
    $minUpgradeFrom = '0.0.0';  //minimum version of module supported for upgrade
    $success        = false;
                Severity: Minor
                Found in include/onupdate.inc.php - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (is_array($sz)) {
            if (array_key_exists('width', $sz)) {
                $this->image_width = (int)$sz['width'];
                if (array_key_exists('height', $sz)) {
                    $this->image_height = (int)$sz['height'];
                  Severity: Major
                  Found in class/providers/nemui.php and 1 other location - About 1 hr to fix
                  class/providers/heartrails.php on lines 84..96

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 114.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if (is_array($sz)) {
                if (array_key_exists('width', $sz)) {
                    $this->image_width = (int)$sz['width'];
                    if (array_key_exists('height', $sz)) {
                        $this->image_height = (int)$sz['height'];
                  Severity: Major
                  Found in class/providers/heartrails.php and 1 other location - About 1 hr to fix
                  class/providers/nemui.php on lines 84..99

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 114.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method b_system_notification_show has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function b_system_notification_show()
{
    global $xoopsConfig, $xoopsUser, $xoopsModule;
    include_once XOOPS_ROOT_PATH . '/include/notification_functions.php';
    include_once XOOPS_ROOT_PATH . '/language/' . $xoopsConfig['language'] . '/notification.php';
                  Severity: Minor
                  Found in extras/XOOPS_2.5.x/htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                    Function MakeFontDescriptor has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function MakeFontDescriptor($fm,$symbolic)
{
  //Ascent
  $asc=(isset($fm['Ascender']) ? $fm['Ascender'] : 1000);
  $fd="array('Ascent'=>".$asc;
                    Severity: Minor
                    Found in fpdf/font/makefont/makefont.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function extract_post_recursive has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                            public function extract_post_recursive($key_name, $tmp_array)
        {
            $table = '';
            $form  = '';
            foreach ($tmp_array as $key => $val) {
                    Severity: Minor
                    Found in include/gtickets.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method MakeFontDescriptor has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function MakeFontDescriptor($fm,$symbolic)
{
  //Ascent
  $asc=(isset($fm['Ascender']) ? $fm['Ascender'] : 1000);
  $fd="array('Ascent'=>".$asc;
                    Severity: Minor
                    Found in fpdf/font/makefont/makefont.php - About 1 hr to fix

                      Method xoops_module_pre_install_mylinks_base has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function xoops_module_pre_install_mylinks_base(&$xoopsModule)
{
    global $xoopsDB;
    $retVal = true;
                      Severity: Minor
                      Found in include/oninstall.inc.php - About 1 hr to fix

                        Method b_system_main_show has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function b_system_main_show()
{
    global $xoopsUser, $xoopsModule;
    $block               = array();
    $block['lang_home']  = _MB_SYSTEM_HOME;
                        Severity: Minor
                        Found in extras/XOOPS_2.5.x/htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language