Sign upLogin

XoopsModules25x/tag

View on GitHub
Star
admin/admin.tag.php

Summary

Maintainability
A
1 hr
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

if ($result instanceof \mysqli_result) {
    while (false !== ($myrow = $GLOBALS['xoopsDB']->fetchArray($result))) {
        $counts_module[$myrow['tag_modid']] = $myrow['count_tag'];
    }
    if (!empty($counts_module)) {
Severity: Major
Found in admin/admin.tag.php and 1 other location - About 1 hr to fix
admin/syn.tag.php on lines 42..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line exceeds 120 characters; contains 123 characters
Open

/** {#internal use direct SQL instead of Tag\TagHandler CRUD operations because XOOPS can't handle COUNT(DISTINCT xx) }} */
Severity: Minor
Found in admin/admin.tag.php by phpcodesniffer

Line exceeds 120 characters; contains 151 characters
Open

    $helper->redirect("admin/admin.tag.php?modid={$modid}&start={$start}&status={$status}", Constants::REDIRECT_DELAY_MEDIUM, $msg_db_updated);
Severity: Minor
Found in admin/admin.tag.php by phpcodesniffer

Line exceeds 120 characters; contains 132 characters
Open

        $module_list   = $moduleHandler->getList(new \Criteria('mid', '(' . implode(', ', array_keys($counts_module)) . ')', 'IN'));
Severity: Minor
Found in admin/admin.tag.php by phpcodesniffer

Line exceeds 120 characters; contains 143 characters
Open

$sql    = 'SELECT tag_modid, COUNT(DISTINCT tag_id) AS count_tag' . ' FROM ' . $GLOBALS['xoopsDB']->prefix('tag_link') . ' GROUP BY tag_modid';
Severity: Minor
Found in admin/admin.tag.php by phpcodesniffer

There are no issues that match your filters.

Category
Status