Function setType
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function setType($value = ''): void
{
if ('' !== $value) {
if (\is_array($value)) {
$value = isset($value['type']) ? \mb_strtolower($value['type']) : 'text';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method setType
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function setType($value = ''): void
{
if ('' !== $value) {
if (\is_array($value)) {
$value = isset($value['type']) ? \mb_strtolower($value['type']) : 'text';
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct($caption, $name, $size, $maxlength, $value = '', string $type = 'text')
The method setType() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
public function setType($value = ''): void
{
if ('' !== $value) {
if (\is_array($value)) {
$value = isset($value['type']) ? \mb_strtolower($value['type']) : 'text';
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method setType uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$value = isset($value) ? \mb_strtolower($value) : 'text';
$this->_type = \in_array($value, $this->_htmlTypes, true) ? $value : 'text';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method setType uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->_type = 'text';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The property $_type is not named in camelCase. Open
class FormValidatedInput extends \XoopsFormText
{
/**
* Initial type
*
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The property $_htmlTypes is not named in camelCase. Open
class FormValidatedInput extends \XoopsFormText
{
/**
* Initial type
*
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
Property name "$_type" should not be prefixed with an underscore to indicate visibility Open
private $_type;
- Exclude checks
Property name "$_htmlTypes" should not be prefixed with an underscore to indicate visibility Open
private $_htmlTypes;
- Exclude checks
Line exceeds 120 characters; contains 293 characters Open
return "<input type='" . $this->_type . "' name='" . $this->getName() . "' title='" . $this->getTitle() . "' id='" . $this->getName() . "' size='" . $this->getSize() . "' maxlength='" . $this->getMaxlength() . "' value='" . $this->getValue() . "'" . $classes . $this->getExtra() . '>';
- Exclude checks