Sign upLogin

XoopsModules25x/tag

View on GitHub
Star
class/TagHandler.php

Summary

Maintainability
F
3 days
Test Coverage

updateByItem accesses the super-global variable $GLOBALS.
Open

    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
Severity: Minor
Found in class/TagHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

updateByItem accesses the super-global variable $GLOBALS.
Open

    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
Severity: Minor
Found in class/TagHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getByItem accesses the super-global variable $GLOBALS.
Open

    public function getByItem(int $itemid, int $modid = 0, int $catid = 0): array
    {
        $ret = [];

        $modid  = (empty($modid) && \is_object($GLOBALS['xoopsModule'])
Severity: Minor
Found in class/TagHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getByItem accesses the super-global variable $GLOBALS.
Open

    public function getByItem(int $itemid, int $modid = 0, int $catid = 0): array
    {
        $ret = [];

        $modid  = (empty($modid) && \is_object($GLOBALS['xoopsModule'])
Severity: Minor
Found in class/TagHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getByItem accesses the super-global variable $GLOBALS.
Open

    public function getByItem(int $itemid, int $modid = 0, int $catid = 0): array
    {
        $ret = [];

        $modid  = (empty($modid) && \is_object($GLOBALS['xoopsModule'])
Severity: Minor
Found in class/TagHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

updateByItem accesses the super-global variable $GLOBALS.
Open

    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
Severity: Minor
Found in class/TagHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

updateByItem accesses the super-global variable $GLOBALS.
Open

    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
Severity: Minor
Found in class/TagHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

updateByItem accesses the super-global variable $GLOBALS.
Open

    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
Severity: Minor
Found in class/TagHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

cleanOrphan accesses the super-global variable $GLOBALS.
Open

    public function cleanOrphan($table_link = '', $field_link = '', $field_object = ''): bool
    {
        require_once $GLOBALS['xoops']->path('/modules/tag/functions.recon.php');

        //mod_loadFunctions("recon");
Severity: Minor
Found in class/TagHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function updateByItem has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
Severity: Minor
Found in class/TagHandler.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File TagHandler.php has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

namespace XoopsModules\Tag;

/*
Severity: Minor
Found in class/TagHandler.php - About 5 hrs to fix

    Function update_stats has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
    Severity: Minor
    Found in class/TagHandler.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The class TagHandler has an overall complexity of 97 which is very high. The configured complexity threshold is 50.
    Open

    class TagHandler extends \XoopsPersistableObjectHandler
{
    public $table_link;
    public $table_stats;
    Severity: Minor
    Found in class/TagHandler.php by phpmd

    Method updateByItem has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
    Severity: Major
    Found in class/TagHandler.php - About 3 hrs to fix

      Method update_stats has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
      Severity: Major
      Found in class/TagHandler.php - About 2 hrs to fix

        Method getByLimit has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
    {//&getByLimit($criteria = null, $fromStats = true)
        $ret = [];
        if ($fromStats) {
            $sql = "SELECT DISTINCT(o.{$this->keyName}), o.tag_term, o.tag_status, SUM(l.tag_count) AS count , l.tag_modid" . " FROM {$this->table} AS o LEFT JOIN {$this->table_stats} AS l ON l.{$this->keyName} = o.{$this->keyName}";
        Severity: Major
        Found in class/TagHandler.php - About 2 hrs to fix

          Method getItems has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getItems(\CriteriaElement $criteria = null): array
    {
        $ret = [];
        $sql = '    SELECT o.tl_id, o.tag_itemid, o.tag_modid, o.tag_catid, o.tag_time';
        $sql .= "    FROM {$this->table_link} AS o LEFT JOIN {$this->table} AS l ON l.{$this->keyName} = o.{$this->keyName}";
          Severity: Minor
          Found in class/TagHandler.php - About 1 hr to fix

            Function getByLimit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
    {//&getByLimit($criteria = null, $fromStats = true)
        $ret = [];
        if ($fromStats) {
            $sql = "SELECT DISTINCT(o.{$this->keyName}), o.tag_term, o.tag_status, SUM(l.tag_count) AS count , l.tag_modid" . " FROM {$this->table} AS o LEFT JOIN {$this->table_stats} AS l ON l.{$this->keyName} = o.{$this->keyName}";
            Severity: Minor
            Found in class/TagHandler.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getItems has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getItems(\CriteriaElement $criteria = null): array
    {
        $ret = [];
        $sql = '    SELECT o.tl_id, o.tag_itemid, o.tag_modid, o.tag_catid, o.tag_time';
        $sql .= "    FROM {$this->table_link} AS o LEFT JOIN {$this->table} AS l ON l.{$this->keyName} = o.{$this->keyName}";
            Severity: Minor
            Found in class/TagHandler.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getTagData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
            Severity: Minor
            Found in class/TagHandler.php - About 1 hr to fix

              Function getItemCount has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
              Severity: Minor
              Found in class/TagHandler.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getByLimit has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
              Severity: Minor
              Found in class/TagHandler.php - About 35 mins to fix

                Function getByItem has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getByItem(int $itemid, int $modid = 0, int $catid = 0): array
    {
        $ret = [];

        $modid  = (empty($modid) && \is_object($GLOBALS['xoopsModule'])
                Severity: Minor
                Found in class/TagHandler.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                The method getByLimit() has an NPath complexity of 2016. The configured NPath complexity threshold is 200.
                Open

                    public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
    {//&getByLimit($criteria = null, $fromStats = true)
        $ret = [];
        if ($fromStats) {
            $sql = "SELECT DISTINCT(o.{$this->keyName}), o.tag_term, o.tag_status, SUM(l.tag_count) AS count , l.tag_modid" . " FROM {$this->table} AS o LEFT JOIN {$this->table_stats} AS l ON l.{$this->keyName} = o.{$this->keyName}";
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
    function bar() {
        // lots of complicated code
    }
}

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method updateByItem() has an NPath complexity of 35910. The configured NPath complexity threshold is 200.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
    function bar() {
        // lots of complicated code
    }
}

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method update_stats() has 103 lines of code. Current threshold is set to 100. Avoid really long methods.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                The method update_stats() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method updateByItem() has a Cyclomatic Complexity of 24. The configured cyclomatic complexity threshold is 10.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method getByLimit() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
                Open

                    public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
    {//&getByLimit($criteria = null, $fromStats = true)
        $ret = [];
        if ($fromStats) {
            $sql = "SELECT DISTINCT(o.{$this->keyName}), o.tag_term, o.tag_status, SUM(l.tag_count) AS count , l.tag_modid" . " FROM {$this->table} AS o LEFT JOIN {$this->table_stats} AS l ON l.{$this->keyName} = o.{$this->keyName}";
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method getItems() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                Open

                    public function getItems(\CriteriaElement $criteria = null): array
    {
        $ret = [];
        $sql = '    SELECT o.tl_id, o.tag_itemid, o.tag_modid, o.tag_catid, o.tag_time';
        $sql .= "    FROM {$this->table_link} AS o LEFT JOIN {$this->table} AS l ON l.{$this->keyName} = o.{$this->keyName}";
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                Missing class import via use statement (line '239', column '36').
                Open

                                $criteria->add(new \Criteria('tag_modid', (string)$modid), 'AND');
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '198', column '32').
                Open

                            $criteria->add(new \Criteria('tag_catid', (string)$catid), 'AND');
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '144', column '47').
                Open

                                $tags_id = &$this->getIds(new \Criteria('tag_term', $tag));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '240', column '36').
                Open

                                $criteria->add(new \Criteria('tag_catid', (string)$catid), 'AND');
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '195', column '32').
                Open

                            $criteria->add(new \Criteria('tag_modid', (string)$modid), 'AND');
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '193', column '28').
                Open

                        $criteria    = new \CriteriaCompo(new \Criteria('tag_id', (string)$tag_id));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '120', column '47').
                Open

                            $tags_id     = &$this->getIds(new \Criteria('tag_term', '(' . \implode(', ', $tags_delete) . ')', 'IN'));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '193', column '47').
                Open

                        $criteria    = new \CriteriaCompo(new \Criteria('tag_id', (string)$tag_id));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '222', column '52').
                Open

                                $criteria = new \CriteriaCompo(new \Criteria($this->keyName, (string)$tag_id));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                The method getByLimit has a boolean flag argument $fromStats, which is a certain sign of a Single Responsibility Principle violation.
                Open

                    public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                BooleanArgumentFlag

                Since: 1.4.0

                A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                Example

                class Foo {
    public function bar($flag = true) {
    }
}

                Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                Missing class import via use statement (line '588', column '28').
                Open

                        $criteria    = new \Criteria($this->keyName, $object->getVar($this->keyName));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '238', column '52').
                Open

                                $criteria = new \CriteriaCompo(new \Criteria($this->keyName, (string)$tag_id));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '224', column '36').
                Open

                                $criteria->add(new \Criteria('tag_catid', $catid), 'AND');
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '238', column '33').
                Open

                                $criteria = new \CriteriaCompo(new \Criteria($this->keyName, (string)$tag_id));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                The method delete has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
                Open

                    public function delete(\XoopsObject $object, $force = true): bool
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                BooleanArgumentFlag

                Since: 1.4.0

                A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                Example

                class Foo {
    public function bar($flag = true) {
    }
}

                Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                Missing class import via use statement (line '223', column '36').
                Open

                                $criteria->add(new \Criteria('tag_modid, $modid'), 'AND');
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '222', column '33').
                Open

                                $criteria = new \CriteriaCompo(new \Criteria($this->keyName, (string)$tag_id));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '601', column '29').
                Open

                        $criteria     = new \Criteria($this->keyName, $object->getVar($this->keyName));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Avoid assigning values to variables in if clauses and the like (line '164', column '32').
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                Avoid assigning values to variables in if clauses and the like (line '128', column '32').
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                The method updateByItem uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                    $tagObj = $this->create();
                    $tagObj->setVars(['tag_term' => $tag, 'tag_count' => 1]);
                    $this->insert($tagObj);
                    $tag_id = $tagObj->getVar('tag_id');
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid assigning values to variables in if clauses and the like (line '133', column '32').
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                The method updateByItem uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                /** @var \XoopsModuleHandler $moduleHandler */
                $moduleHandler = \xoops_getHandler('module');
                $modid         = ($moduleObj = $moduleHandler->getByDirname($modid)) ? $moduleObj->getVar('mid') : 0;
            }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method update_stats uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
            $statsHandler = Helper::getInstance()->getHandler('Stats');
            if (empty($count)) {
                $criteria = new \CriteriaCompo(new \Criteria($this->keyName, (string)$tag_id));
                $criteria->add(new \Criteria('tag_modid, $modid'), 'AND');
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid assigning values to variables in if clauses and the like (line '123', column '32').
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                Avoid assigning values to variables in if clauses and the like (line '159', column '28').
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                Avoid using static access to class 'XoopsModules\Tag\Utility' in method 'updateByItem'.
                Open

                            $tags = Utility::tag_parse_tag(\addslashes(\stripslashes($tags)));
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                StaticAccess

                Since: 1.4.0

                Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                Example

                class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                Source https://phpmd.org/rules/cleancode.html#staticaccess

                The method update_stats uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                    $tagObj->setVar('tag_count', $count);
                    $this->insert($tagObj, true);
                }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method getByLimit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
            \trigger_error($this->db->error());
            $ret = null;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method getItems uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
            \trigger_error($this->db->error());
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method getItemCount uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                \trigger_error($this->db->error());
                $ret = 0;
            }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method getCount uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
            \trigger_error($this->db->error());
            $ret = 0;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid assigning values to variables in if clauses and the like (line '463', column '13').
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                The method update_stats uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                $ts_id    = null;
                $criteria = new \CriteriaCompo(new \Criteria($this->keyName, (string)$tag_id));
                $criteria->add(new \Criteria('tag_modid', (string)$modid), 'AND');
                $criteria->add(new \Criteria('tag_catid', (string)$catid), 'AND');
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method update_stats uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                    $newTsObj = $statsHandler->create();
                    $newTsObj->setVars(
                        [
                            'tag_id'    => $tag_id,
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid using static access to class '\XoopsModules\Tag\Helper' in method 'delete'.
                Open

                        $helper = \XoopsModules\Tag\Helper::getInstance();
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                StaticAccess

                Since: 1.4.0

                Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                Example

                class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                Source https://phpmd.org/rules/cleancode.html#staticaccess

                The method getByLimit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
            $sql = "SELECT DISTINCT(o.{$this->keyName}), o.tag_term, o.tag_status, COUNT(l.tl_id) AS count , l.tag_modid" . " FROM {$this->table} AS o LEFT JOIN {$this->table_link} AS l ON l.{$this->keyName} = o.{$this->keyName}";
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid unused local variables such as '$result'.
                Open

                                if (false === ($result = $this->db->queryF($sql))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                UnusedLocalVariable

                Since: 0.2

                Detects when a local variable is declared and/or assigned, but not used.

                Example

                class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

                Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                Avoid unused local variables such as '$sql'.
                Open

                                $sql = '';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                UnusedLocalVariable

                Since: 0.2

                Detects when a local variable is declared and/or assigned, but not used.

                Example

                class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

                Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                Avoid unused parameters such as '$field_link'.
                Open

                    public function cleanOrphan($table_link = '', $field_link = '', $field_object = ''): bool
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                Avoid unused parameters such as '$table_link'.
                Open

                    public function cleanOrphan($table_link = '', $field_link = '', $field_object = ''): bool
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                Avoid unused parameters such as '$fields'.
                Open

                    public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                Avoid unused parameters such as '$field_object'.
                Open

                    public function cleanOrphan($table_link = '', $field_link = '', $field_object = ''): bool
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                The property $table_stats is not named in camelCase.
                Open

                class TagHandler extends \XoopsPersistableObjectHandler
{
    public $table_link;
    public $table_stats;
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCasePropertyName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name attributes.

                Example

                class ClassName {
    protected $property_name;
}

                Source

                Avoid variables with short names like $db. Configured minimum length is 3.
                Open

                    public function __construct(?\XoopsMySQLDatabase $db = null)
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                The property $table_link is not named in camelCase.
                Open

                class TagHandler extends \XoopsPersistableObjectHandler
{
    public $table_link;
    public $table_stats;
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCasePropertyName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name attributes.

                Example

                class ClassName {
    protected $property_name;
}

                Source

                The parameter $tag_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $tags_array is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $table_link is not named in camelCase.
                Open

                    public function cleanOrphan($table_link = '', $field_link = '', $field_object = ''): bool
    {
        require_once $GLOBALS['xoops']->path('/modules/tag/functions.recon.php');

        //mod_loadFunctions("recon");
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $field_object is not named in camelCase.
                Open

                    public function cleanOrphan($table_link = '', $field_link = '', $field_object = ''): bool
    {
        require_once $GLOBALS['xoops']->path('/modules/tag/functions.recon.php');

        //mod_loadFunctions("recon");
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $tag_id is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 28 and the first side effect is on line 23.
                Open

                <?php declare(strict_types=1);
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                The parameter $font_min is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $font_max is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $field_link is not named in camelCase.
                Open

                    public function cleanOrphan($table_link = '', $field_link = '', $field_object = ''): bool
    {
        require_once $GLOBALS['xoops']->path('/modules/tag/functions.recon.php');

        //mod_loadFunctions("recon");
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                Method name "TagHandler::update_stats" is not in camel caps format
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 153 characters
                Open

                            $sql = "INSERT INTO {$this->table_link}" . ' (tag_id, tag_itemid, tag_catid, tag_modid, tag_time) ' . ' VALUES ' . \implode(', ', $tag_link);
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 219 characters
                Open

                                $sql = "DELETE FROM {$this->table_link}" . ' WHERE ' . "     {$this->keyName} IN (" . \implode(', ', $tags_id) . ')' . "     AND tag_modid = {$modid} AND tag_catid = {$catid} AND tag_itemid = {$itemid}";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 164 characters
                Open

                                $sql = "DELETE FROM {$this->table_stats}" . ' WHERE ' . " {$this->keyName} = {$tag_id}" . " AND tag_modid = {$modid}" . " AND tag_catid = {$catid}";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 233 characters
                Open

                            $sql = "SELECT DISTINCT(o.{$this->keyName}), o.tag_term, o.tag_status, SUM(l.tag_count) AS count , l.tag_modid" . " FROM {$this->table} AS o LEFT JOIN {$this->table_stats} AS l ON l.{$this->keyName} = o.{$this->keyName}";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 127 characters
                Open

                            $limit = $limit >= 0 ? $limit : $criteria->getLimit(); // non-zero arg passed to method overrides $criteria setting
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 159 characters
                Open

                                $sql = 'UPDATE ' . $this->table . ' SET tag_count = tag_count+1' . ' WHERE ' . "     {$this->keyName} IN (" . \implode(', ', $tag_count) . ')';
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 165 characters
                Open

                                    //$sql = "INSERT INTO {$this->table_stats}" . ' (tag_id, tag_modid, tag_catid, tag_count)' . " VALUES ({$tag_id}, {$modid}, {$catid}, {$count})";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 131 characters
                Open

                                        //$sql = "UPDATE {$this->table_stats}" . " SET tag_count = {$count}" . ' WHERE ' . "     ts_id = {$ts_id}";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 230 characters
                Open

                            $sql = "SELECT DISTINCT(o.{$this->keyName}), o.tag_term, o.tag_status, COUNT(l.tl_id) AS count , l.tag_modid" . " FROM {$this->table} AS o LEFT JOIN {$this->table_link} AS l ON l.{$this->keyName} = o.{$this->keyName}";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 170 characters
                Open

                        $sql = "SELECT COUNT(DISTINCT o.{$this->keyName})" . "    FROM {$this->table} AS o LEFT JOIN {$this->table_link} AS l ON l.{$this->keyName} = o.{$this->keyName}";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 128 characters
                Open

                        //                     * Font-size = ((tag.count - count.min) * (font.max - font.min) / (count.max - count.min) ) * 100%
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 126 characters
                Open

                                   && 'tag' !== $GLOBALS['xoopsModule']->getVar('dirname')) ? $GLOBALS['xoopsModule']->getVar('mid') : $modid;
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 156 characters
                Open

                                $sql = 'DELETE FROM ' . $this->table . ' WHERE ' . '    tag_count < 2 AND ' . "     {$this->keyName} IN (" . \implode(', ', $tags_id) . ')';
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 171 characters
                Open

                    public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 122 characters
                Open

                        //$sql = 'DELETE' . " FROM {$this->table_link}" . " WHERE  {$this->keyName} = " . $object->getVar($this->keyName);
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 201 characters
                Open

                        $sql   = 'SELECT COUNT(*) ' . " FROM {$this->table_link}" . " WHERE tag_id = {$tag_id}" . (empty($modid) ? '' : " AND tag_modid = {$modid}") . (($catid < 0) ? '' : " AND tag_catid = {$catid}");
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 183 characters
                Open

                                $sql   = 'SELECT ts_id, tag_count ' . " FROM {$this->table_stats}" . " WHERE {$this->keyName} = {$tag_id}" . " AND tag_modid = {$modid}" . " AND tag_catid = {$catid}";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 135 characters
                Open

                            $sql_from   = "    FROM {$this->table_link} AS o LEFT JOIN {$this->table} AS l ON l.{$this->keyName} = o.{$this->keyName}";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 127 characters
                Open

                            $start = $start >= 0 ? $start : $criteria->getStart(); // non-zero arg passed to method overrides $criteria setting
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 125 characters
                Open

                        $sql .= "    FROM {$this->table_link} AS o LEFT JOIN {$this->table} AS l ON l.{$this->keyName} = o.{$this->keyName}";
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 159 characters
                Open

                                $sql = 'UPDATE ' . $this->table . ' SET tag_count = tag_count - 1' . ' WHERE ' . "     {$this->keyName} IN (" . \implode(', ', $tags_id) . ')';
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Line exceeds 120 characters; contains 123 characters
                Open

                        //$sql = 'DELETE' . " FROM {$this->table_stats}" . " WHERE  {$this->keyName} = " . $object->getVar($this->keyName);
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                Opening brace must be the last content on the line
                Open

                    {//&getByLimit($criteria = null, $fromStats = true)
                Severity: Minor
                Found in class/TagHandler.php by phpcodesniffer

                The variable $tags_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_update is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_existing is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_delete is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_update is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_link is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_count is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_update is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_add is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_existing is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_count is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_add is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_existing is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_count is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_delete is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_count is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_update is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_count is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_link is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $sql_select is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_count is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $ts_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_delete is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_delete is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_link is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_delete is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_count is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_add is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_id is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_update is not named in camelCase.
                Open

                    public function updateByItem($tags, int $itemid, $modid = '', int $catid = 0): bool
    {
        if (!empty($modid) && !\is_numeric($modid)) {
            if (($GLOBALS['xoopsModule'] instanceof \XoopsModule)
                && ($modid == $GLOBALS['xoopsModule']->getVar('dirname'))) {
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $ts_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_max is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_interval is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_max is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $sql_from is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_min is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $sql_from is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_min is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_interval is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $font_min is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_max is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_interval is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_min is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_term is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $font_ratio is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_array is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_data_array is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $sql_select is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_term is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_data_array is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $sql_where is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tag_id is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $sql_where is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_max is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_max is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_min is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $level_limit is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $font_ratio is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $font_max is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_data_array is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_interval is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $sql_where is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $level_limit is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $sql_where is not named in camelCase.
                Open

                    public function getItemCount(int $tag_id, int $modid = 0, int $catid = 0): int
    {
        $ret = 0;
        if ($tag_id = $tag_id) {
            $sql_select = '    SELECT COUNT(DISTINCT o.tl_id)';
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_array is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_term is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_max is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_min is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $count_min is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $font_min is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $ts_id is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_term is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The variable $tags_array is not named in camelCase.
                Open

                    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseVariableName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name variables.

                Example

                class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                Source

                The method update_stats is not named in camelCase.
                Open

                    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
                Severity: Minor
                Found in class/TagHandler.php by phpmd

                CamelCaseMethodName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name methods.

                Example

                class ClassName {
    public function get_name() {
    }
}

                Source

                There are no issues that match your filters.

                Category
                Status