XoopsModules25x/tag

View on GitHub

Showing 1,477 of 1,477 total issues

The variable $ts_id is not named in camelCase.
Open

    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
Severity: Minor
Found in class/TagHandler.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tags_term is not named in camelCase.
Open

    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
Severity: Minor
Found in class/TagHandler.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tags_array is not named in camelCase.
Open

    public function getTagData(array $tags_array, int $font_max = 0, int $font_min = 0): array
    {
        //        $tags_data_array = [];
        //        if (\is_array($tags_array) && !empty($tags_array)) {
        //            // set min and max tag count
Severity: Minor
Found in class/TagHandler.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $args_string is not named in camelCase.
Open

    public static function tag_parse_args(&$args, &$args_string): bool
    {
        $args_abb    = [
            'c' => 'catid',
            'm' => 'modid',
Severity: Minor
Found in class/Utility.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method test__construct is not named in camelCase.
Open

    public function test__construct(): void
    {
    }
Severity: Minor
Found in tests/FormTagTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method update_stats is not named in camelCase.
Open

    public function update_stats(int $tag_id, int $modid = 0, int $catid = 0): bool
    {
        if (0 === $tag_id) {
            return true;
        }
Severity: Minor
Found in class/TagHandler.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method tag_define_url_delimiter is not named in camelCase.
Open

    public static function tag_define_url_delimiter(): void
    {
        if (\defined('URL_DELIMITER')) {
            if (!\in_array(URL_DELIMITER, ['?', '/'], true)) {
                exit('Security Violation');
Severity: Minor
Found in class/Utility.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method tag_get_delimiter is not named in camelCase.
Open

    public static function tag_get_delimiter()
    {
        \XoopsModules\Tag\Helper::getInstance()->loadLanguage('config');
        //xoops_loadLanguage('config', 'tag');
        $retVal = [',', ' ', '|', ';'];
Severity: Minor
Found in class/Utility.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method tag_parse_tag is not named in camelCase.
Open

    public static function tag_parse_tag(string $text_tag): array
    {
        $tags = [];
        if (!empty($text_tag)) {
            $delimiters = self::tag_get_delimiter();
Severity: Minor
Found in class/Utility.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method tag_parse_args is not named in camelCase.
Open

    public static function tag_parse_args(&$args, &$args_string): bool
    {
        $args_abb    = [
            'c' => 'catid',
            'm' => 'modid',
Severity: Minor
Found in class/Utility.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method tag_load_config is not named in camelCase.
Open

    public static function tag_load_config()
    {
        static $moduleConfig;

        if (null === $moduleConfig) {
Severity: Minor
Found in class/Utility.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

TODO found
Open

                \curl_setopt($curlHandle, \CURLOPT_SSL_VERIFYPEER, true); //TODO: how to avoid an error when 'Peer's Certificate issuer is not recognized'
Severity: Minor
Found in class/Common/VersionChecks.php by fixme

TODO found
Open

     * @TODO: Refactor to consider HTML5 & void (self-closing) elements
Severity: Minor
Found in class/Common/SysUtility.php by fixme

TODO found
Open

        TODO if you want to use the render code below,
Severity: Minor
Found in class/Common/Breadcrumb.php by fixme

TODO found
Open

     * @TODO need to exit more gracefully on error. Should throw/trigger error and then return false
Severity: Minor
Found in class/Common/SysUtility.php by fixme

TODO found
Open

     * @TODO: Consider using https://github.com/jlgrall/truncateHTML/blob/master/truncateHTML.php
Severity: Minor
Found in class/Common/SysUtility.php by fixme

TODO found
Open

TODO: Planned features in the future
Severity: Minor
Found in docs/todo.txt by fixme
Severity
Category
Status
Source
Language