Sign upLogin

XoopsModules25x/tag

View on GitHub
Star
plugin/xmnews.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method xmnews_tag_iteminfo has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
Severity: Minor
Found in plugin/xmnews.php - About 1 hr to fix

    Function xmnews_tag_iteminfo has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '40', column '49').
    Open

        $items_obj   = $newsHandler->getObjects(new \Criteria('news_id', '(' . implode(', ', $items_id) . ')', 'IN'), true);
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\XoopsModules\Tag\Utility' in method 'xmnews_tag_iteminfo'.
    Open

                        'tags'    => \XoopsModules\Tag\Utility::tag_parse_tag($item_obj->getVar('news_mkeyword', 'n')), // optional
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Module\Helper' in method 'xmnews_tag_iteminfo'.
    Open

        $helper      = Helper::getHelper('xmnews');
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Module\Helper' in method 'xmnews_tag_synchronization'.
    Open

        $helper      = Helper::getHelper('xmnews');
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'xmnews_tag_synchronization'.
    Open

        $mid = \Xmf\Request::getInt('mid');
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The variable $item_obj is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_obj is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_obj is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_obj is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_obj is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xmnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xmnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status