Sign upLogin

XoopsModules25x/tag

View on GitHub
Star
plugin/xnews.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method xnews_tag_iteminfo has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
Severity: Minor
Found in plugin/xnews.php - About 1 hr to fix

    Function xnews_tag_iteminfo has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method xnews_tag_synchronization uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

        } else {
        $sql = "DELETE {$linkHandler->table}";
        $sql .= " FROM {$linkHandler->table}";
        $sql .= " LEFT JOIN {$itemHandler_table} AS aa ON {$linkHandler->table}.tag_itemid = aa.{$itemHandler_keyName} ";
        $sql .= " WHERE tag_modid = {$mid} AND ( aa.{$itemHandler_keyName} IS NULL OR {$where})";
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid assigning values to variables in if clauses and the like (line '79', column '10').
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\XoopsModules\Tag\Utility' in method 'xnews_tag_iteminfo'.
    Open

                        'tags'    => Utility::tag_parse_tag($item_obj->tags()), // optional
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused local variables such as '$result'.
    Open

        if (!$result = $linkHandler->db->queryF($sql)) {
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Line exceeds 120 characters; contains 121 characters
    Open

            $sql .= " LEFT JOIN {$itemHandler_table} AS aa ON {$linkHandler->table}.tag_itemid = aa.{$itemHandler_keyName} ";
    Severity: Minor
    Found in plugin/xnews.php by phpcodesniffer

    Line exceeds 120 characters; contains 127 characters
    Open

        // $linkHandler = \XoopsModules\Tag\Helper::getInstance()->getHandler('Link'); //@var \XoopsModules\Tag\Handler $tagHandler
    Severity: Minor
    Found in plugin/xnews.php by phpcodesniffer

    Line exceeds 120 characters; contains 151 characters
    Open

            $sql .= " WHERE tag_modid = {$mid} AND (tag_itemid NOT IN (SELECT DISTINCT {$itemHandler_keyName} FROM {$itemHandler_table} WHERE {$where}) )";
    Severity: Minor
    Found in plugin/xnews.php by phpcodesniffer

    Line exceeds 120 characters; contains 199 characters
    Open

        $where       = "({$itemHandler_table}.published > 0 AND {$itemHandler_table}.published <= " . time() . ") AND ({$itemHandler_table}.expired = 0 OR {$itemHandler_table}.expired > " . time() . ')';
    Severity: Minor
    Found in plugin/xnews.php by phpcodesniffer

    The variable $items_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_keyName is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_table is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_table is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_table is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_table is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_keyName is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_keyName is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_table is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_table is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $cat_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_table is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $itemHandler_keyName is not named in camelCase.
    Open

    function xnews_tag_synchronization(int $mid): void
{
    global $xoopsDB;
    $itemHandler_keyName = 'storyid';
    $itemHandler_table   = $xoopsDB->prefix('nw_stories');
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $item_id is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $items_obj is not named in camelCase.
    Open

    function xnews_tag_iteminfo(array &$items): bool
{
    if (empty($items)) {
        return false;
    }
    Severity: Minor
    Found in plugin/xnews.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status