Function loginregHistoryShow
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method loginregHistoryShow
has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
Method loginregHistoryForm
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function loginregHistoryForm($args, $eleNamePrefix = 'options')
{
// require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
xoops_load('XoopsFormLoader');
// $form = new XoopsBlockForm(); //reserve for 2.6
Method stats_typeForm
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function stats_typeForm($args, $eleNamePrefix = 'options')
{
// require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
xoops_load('XoopsFormLoader');
// $form = new XoopsBlockForm(); //reserve for 2.6
The method loginregHistoryShow() has an NPath complexity of 544. The configured NPath complexity threshold is 200. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method loginregHistoryShow() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using undefined variables such as '$opt' which will lead to PHP notices. Open
$criteria->add(new Criteria('post', '%level%', $opt[$args[$i]]), 'AND'); // inactive "NOT LIKE" active "LIKE"
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$opt' which will lead to PHP notices. Open
$criteria->add(new Criteria('post', '%last_visit%', $opt[$args[$i]]), 'AND'); // never login before "NOT LIKE" login before "LIKE"
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$opt' which will lead to PHP notices. Open
$opt[2] = 'LIKE';
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$opt' which will lead to PHP notices. Open
$criteria->add(new Criteria('post', '%vpass%', $opt[$args[$i]]), 'AND'); // login "NOT LIKE" register "LIKE"
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$opt' which will lead to PHP notices. Open
$opt[0] = 0;
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$opt' which will lead to PHP notices. Open
$opt[1] = 'NOT LIKE';
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$opt' which will lead to PHP notices. Open
$criteria->add(new Criteria('post', '%success%', $opt[$args[$i]]), 'AND'); // falied "NOT LIKE" success "LIKE"
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Missing class import via use statement (line '274', column '25'). Open
$criteria = new CriteriaCompo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '226', column '21'). Open
$form = new XoopsThemeForm(_AM_USERLOG_STATS_TYPE, 'stats_type', '');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '72', column '28'). Open
$criteria->add(new Criteria('uid', 0), 'AND');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '171', column '34'). Open
$lastVisitRadioEle = new XoopsFormRadio(_AM_USERLOG_LAST_LOGIN, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '241', column '24'). Open
$sortEle = new XoopsFormSelect(_AM_USERLOG_SORT, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '281', column '28'). Open
$criteria->add(new Criteria('referer', "{$refLike}", 'LIKE'), 'AND'); // modules admin
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '74', column '28'). Open
$criteria->add(new Criteria('post', '%login_patch%', 'LIKE'), 'AND'); // login/register was patched
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '89', column '32'). Open
$criteria->add(new Criteria('post', '%level%', $opt[$args[$i]]), 'AND'); // inactive "NOT LIKE" active "LIKE"
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '232', column '24'). Open
$typeEle = new XoopsFormSelect(_AM_USERLOG_STATS_TYPE, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '153', column '33'). Open
$loginRegRadioEle = new XoopsFormRadio(_LOGIN . '|' . _REGISTER, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '275', column '28'). Open
$criteria->add(new Criteria('module', 'system'), 'AND');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '71', column '25'). Open
$criteria = new CriteriaCompo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '93', column '32'). Open
$criteria->add(new Criteria('post', '%last_visit%', $opt[$args[$i]]), 'AND'); // never login before "NOT LIKE" login before "LIKE"
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '159', column '32'). Open
$failSucRadioEle = new XoopsFormRadio(_AM_USERLOG_FAIL . '|' . _AM_USERLOG_SUCCESS, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '250', column '25'). Open
$orderEle = new XoopsFormSelect(_AM_USERLOG_ORDER, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '73', column '28'). Open
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '165', column '39'). Open
$inactiveActiveRadioEle = new XoopsFormRadio(_MA_USER_LEVEL_INACTIVE . '|' . _MA_USER_LEVEL_ACTIVE, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '146', column '21'). Open
$form = new XoopsThemeForm(_AM_USERLOG_LOGIN_REG_HISTORY, 'login_reg_history', '');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '178', column '25'). Open
$orderEle = new XoopsFormSelect(_AM_USERLOG_ORDER, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '230', column '28'). Open
$numitemsEle = new XoopsFormText(_AM_USERLOG_ITEMS_NUM, "{$eleNamePrefix}[{$i}]", 10, 255, (int)$args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '85', column '32'). Open
$criteria->add(new Criteria('post', '%success%', $opt[$args[$i]]), 'AND'); // falied "NOT LIKE" success "LIKE"
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '81', column '32'). Open
$criteria->add(new Criteria('post', '%vpass%', $opt[$args[$i]]), 'AND'); // login "NOT LIKE" register "LIKE"
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '150', column '28'). Open
$numitemsEle = new XoopsFormText(_AM_USERLOG_ITEMS_NUM, "{$eleNamePrefix}[{$i}]", 10, 255, (int)$args[$i]);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '276', column '28'). Open
$criteria->add(new Criteria('request_method', 'POST'), 'AND'); // only POST method
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'Userlog' in method '__construct'. Open
$this->userlog = Userlog::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'UserlogStats' in method 'stats_typeShow'. Open
$statsObj = UserlogStats::getInstance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method loginregHistoryShow uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block[$log_id]['msg'] .= _MA_USER_LEVEL_ACTIVE;
$block[$log_id]['color'] = 'GREEN';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method loginregHistoryShow uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block[$log_id]['success'] = 0;
$block[$log_id]['msg'] = _AM_USERLOG_FAIL . ' ';
$block[$log_id]['msg'] .= ('register' === $block[$log_id]['loginOrRegister']) ? _ERRORS : _US_INCORRECTLOGIN;
$block[$log_id]['color'] = 'RED';
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method loginregHistoryShow uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block[$log_id]['msg'] .= ' ' . sprintf(_US_CONFMAIL, $block[$log_id]['uname']);
$block[$log_id]['color'] = 'BROWN';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid excessively long variable names like $inactiveActiveRadioEle. Keep variable name length under 20. Open
$inactiveActiveRadioEle = new XoopsFormRadio(_MA_USER_LEVEL_INACTIVE . '|' . _MA_USER_LEVEL_ACTIVE, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class UserlogQuery
- Exclude checks
Avoid variables with short names like $i. Configured minimum length is 3. Open
$i = 0;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $i. Configured minimum length is 3. Open
$i = 0;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $i. Configured minimum length is 3. Open
$i = 1;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 34 and the first side effect is on line 23. Open
<?php
- Exclude checks
Method name "UserlogQuery::stats_typeForm" is not in camel caps format Open
public function stats_typeForm($args, $eleNamePrefix = 'options')
- Exclude checks
Method name "UserlogQuery::stats_typeShow" is not in camel caps format Open
public function stats_typeShow($args)
- Exclude checks
Line exceeds 120 characters; contains 122 characters Open
$criteria->add(new Criteria('post', '%success%', $opt[$args[$i]]), 'AND'); // falied "NOT LIKE" success "LIKE"
- Exclude checks
Line exceeds 120 characters; contains 129 characters Open
$failSucRadioEle = new XoopsFormRadio(_AM_USERLOG_FAIL . '|' . _AM_USERLOG_SUCCESS, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Exclude checks
Line exceeds 120 characters; contains 121 characters Open
$criteria->add(new Criteria('post', '%level%', $opt[$args[$i]]), 'AND'); // inactive "NOT LIKE" active "LIKE"
- Exclude checks
Line exceeds 120 characters; contains 129 characters Open
$block[$log_id]['msg'] .= ('register' === $block[$log_id]['loginOrRegister']) ? _ERRORS : _US_INCORRECTLOGIN;
- Exclude checks
Line exceeds 120 characters; contains 142 characters Open
$criteria->add(new Criteria('post', '%last_visit%', $opt[$args[$i]]), 'AND'); // never login before "NOT LIKE" login before "LIKE"
- Exclude checks
Line exceeds 120 characters; contains 145 characters Open
$inactiveActiveRadioEle = new XoopsFormRadio(_MA_USER_LEVEL_INACTIVE . '|' . _MA_USER_LEVEL_ACTIVE, "{$eleNamePrefix}[{$i}]", $args[$i]);
- Exclude checks
Line exceeds 120 characters; contains 195 characters Open
$refViews = $statsObj->getAll($args[1], 0, $args[0], $args[2], $args[3]); // getAll($type = array(), $start = 0, $limit = 0, $sort = "stats_value", $order = "DESC", $otherCriteria = null)
- Exclude checks
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $log_id is not named in camelCase. Open
public function loginregHistoryShow($args)
{
$criteria = new CriteriaCompo();
$criteria->add(new Criteria('uid', 0), 'AND');
$criteria->add(new Criteria('post', '%pass%', 'LIKE'), 'AND'); // login or register
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The method stats_typeForm is not named in camelCase. Open
public function stats_typeForm($args, $eleNamePrefix = 'options')
{
// require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
xoops_load('XoopsFormLoader');
// $form = new XoopsBlockForm(); //reserve for 2.6
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}
Source
The method stats_typeShow is not named in camelCase. Open
public function stats_typeShow($args)
{
$statsObj = UserlogStats::getInstance();
$refViews = $statsObj->getAll($args[1], 0, $args[0], $args[2], $args[3]); // getAll($type = array(), $start = 0, $limit = 0, $sort = "stats_value", $order = "DESC", $otherCriteria = null)
if (empty($refViews)) {
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}