Sign upLogin

XoopsModules25x/userlog

View on GitHub
Star

Showing 1,244 of 1,244 total issues

The variable $OSes is not named in camelCase.
Open

    public function updateAll($type = 'log', $prob = 11)
    {
        if (!$this->userlog->probCheck($prob)) {
            return false;
        }
Severity: Minor
Found in class/stats.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method last_login is not named in camelCase.
Open

    public function last_login()
    {
        return $this->userlog->formatTime($this->getVar('last_login'));
    }
Severity: Minor
Found in class/log.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getRemoteData is not named in camelCase.
Open

    protected function _getRemoteData($url)
    {
        ini_set('user_agent', $this->_getUserAgent());

        switch ($this->_getUpdateMethod()) {
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getUserAgent is not named in camelCase.
Open

    protected function _getUserAgent()
    {
        $ua = str_replace('%v', self::VERSION, $this->userAgent);
        $ua = str_replace('%m', $this->_getUpdateMethod(), $ua);
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method unique_id is not named in camelCase.
Open

    public function unique_id()
    {
        if ('ip' === $this->getVar('logby')) {
            return long2ip($this->getVar('unique_id'));
        }
Severity: Minor
Found in class/setting.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getStreamContext is not named in camelCase.
Open

    protected function _getStreamContext($recreate = false)
    {
        if (!isset($this->_streamContext) || true === $recreate) {
            $this->_streamContext = stream_context_create($this->getStreamContextOptions());
        }
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getLocalMTime is not named in camelCase.
Open

    protected function _getLocalMTime()
    {
        if (!is_readable($this->localFile) || !is_file($this->localFile)) {
            throw new Exception('Local file is not readable');
        }
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getRemoteMTime is not named in camelCase.
Open

    protected function _getRemoteMTime()
    {
        $remote_datetime = $this->_getRemoteData($this->remoteVerUrl);
        $remote_tmstp    = strtotime($remote_datetime);
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _deleteCacheFile is not named in camelCase.
Open

    private function _deleteCacheFile($name = null, $root_path = XOOPS_CACHE_PATH)
    {
        if (empty($name)) {
            return false;
        }
Severity: Minor
Found in class/setting.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _array2string is not named in camelCase.
Open

    protected function _array2string($array)
    {
        $content = "array(\n";

        foreach ($array as $key => $value) {
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method stats_typeForm is not named in camelCase.
Open

    public function stats_typeForm($args, $eleNamePrefix = 'options')
    {
        // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
        xoops_load('XoopsFormLoader');
        // $form = new XoopsBlockForm(); //reserve for 2.6
Severity: Minor
Found in class/query.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _buildCache is not named in camelCase.
Open

    protected function _buildCache()
    {
        $content = sprintf(
            "<?php\n\$source_version=%s;\n\$cache_version=%s",
            "'" . $this->_source_version . "'",
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getRemoteIniFile is not named in camelCase.
Open

    protected function _getRemoteIniFile($url, $path)
    {
        // local and remote file are the same, no update possible
        if ($url == $path) {
            return false;
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _createCacheFile is not named in camelCase.
Open

    private function _createCacheFile($data, $name = null, $root_path = XOOPS_CACHE_PATH)
    {
        $name = $name ?: (string)time();
        $key  = USERLOG_DIRNAME . "_{$name}";
Severity: Minor
Found in class/setting.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method stats_typeShow is not named in camelCase.
Open

    public function stats_typeShow($args)
    {
        $statsObj = UserlogStats::getInstance();
        $refViews = $statsObj->getAll($args[1], 0, $args[0], $args[2], $args[3]); // getAll($type = array(), $start = 0, $limit = 0, $sort = "stats_value", $order = "DESC", $otherCriteria = null)
        if (empty($refViews)) {
Severity: Minor
Found in class/query.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getUpdateMethod is not named in camelCase.
Open

    protected function _getUpdateMethod()
    {
        // Caches the result
        if (null === $this->updateMethod) {
            if (null !== $this->localFile) {
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _securityCheck is not named in camelCase.
Open

    protected static function _securityCheck($filename)
    {
        /**
         * Security check
         */
Severity: Minor
Found in class/plugin/plugin.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _pregUnQuote is not named in camelCase.
Open

    protected function _pregUnQuote($pattern, $matches)
    {
        // list of escaped characters: http://www.php.net/manual/en/function.preg-quote.php
        // to properly unescape '?' which was changed to '.', I replace '\.' (real dot) with '\?',
        // then change '.' to '?' and then '\?' to '.'.
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _pregQuote is not named in camelCase.
Open

    protected function _pregQuote($user_agent)
    {
        $pattern = preg_quote($user_agent, self::REGEX_DELIMITER);

        // the \\x replacement is a fix for "Der gro\xdfe BilderSauger 2.00u" user agent match
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _loadCache is not named in camelCase.
Open

    protected function _loadCache($cache_file)
    {
        $cache_version  = null;
        $source_version = null;
        $browsers       = [];
Severity: Minor
Found in class/phpbrowscap/Browscap.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language