Sign upLogin

XoopsModules25x/xlanguage

View on GitHub
Star
class/Language.php

Summary

Maintainability
A
0 mins
Test Coverage

The method __construct has a boolean flag argument $isBase, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($isBase = false)
Severity: Minor
Found in class/Language.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The property $lang_base is not named in camelCase.
Open

class Language extends Xlanguage\Blanguage
{
    public $lang_base;

    /**
Severity: Minor
Found in class/Language.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

There must be one blank line after the last USE statement; 3 found;
Open

use XoopsModules\Xlanguage;
Severity: Minor
Found in class/Language.php by phpcodesniffer

There are no issues that match your filters.

Category
Status