Sign upLogin

XoopsModules25x/xlanguage

View on GitHub
Star

Showing 589 of 589 total issues

Function cleanMultiLang has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public static function cleanMultiLang($text)
    {
        global $xoopsConfig;
        global $xlanguage_langs;
        $patterns = [];
Severity: Minor
Found in class/Utility.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createConfig has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createConfig()
    {
        $file_config = \XLANGUAGE_CONFIG_FILE;
        if (\is_file($file_config)) {
            \unlink($file_config);
Severity: Minor
Found in class/LanguageHandler.php - About 1 hr to fix

    Method cleanMultiLang has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function cleanMultiLang($text)
    {
        global $xoopsConfig;
        global $xlanguage_langs;
        $patterns = [];
    Severity: Minor
    Found in class/Utility.php - About 1 hr to fix

      Method showSelectedLanguage has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function showSelectedLanguage($options = null)
    {
        require_once XOOPS_ROOT_PATH . '/modules/xlanguage/blocks/xlanguage_blocks.php';
        if (empty($options)) {
            $options[0] = 'images'; // display style: image, text, select
      Severity: Minor
      Found in class/Utility.php - About 1 hr to fix

        Method checkVerModule has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function checkVerModule($helper, $source = 'github', $default = 'master')
    {
        $moduleDirName      = \basename(\dirname(__DIR__, 2));
        $moduleDirNameUpper = mb_strtoupper($moduleDirName);
        $update             = '';
        Severity: Minor
        Found in class/Common/VersionChecks.php - About 1 hr to fix

          Function recurseCopy has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function recurseCopy($src, $dst)
    {
        $dir = \opendir($src);
        //        @mkdir($dst);
        if (!@\mkdir($dst) && !\is_dir($dst)) {
          Severity: Minor
          Found in class/Common/FilesManagement.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getPreferredLanguage has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function getPreferredLanguage()
    {
        $langs = [];
        $lang  = '';
        //        if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
          Severity: Minor
          Found in class/Utility.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function loadTableFromArrayWithReplace has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function loadTableFromArrayWithReplace($table, $data, $search, $replace)
{
    /** @var \XoopsMySQLDatabase $db */
    $db = \XoopsDatabaseFactory::getDatabaseConnection();
          Severity: Minor
          Found in testdata/index.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function langDetect has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function langDetect($str = '', $envType = '')
    {
        require dirname(__DIR__) . '/include/vars.php';
        $lang = '';
          Severity: Minor
          Found in class/Utility.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getByName has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getByName($name, $isBase = false)
    {
        $array = [];
        $lang  = null;
        if (empty($name) || \preg_match('/[^a-zA-Z0-9\_\-]/', $name)) {
          Severity: Minor
          Found in class/LanguageHandler.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function detectLang has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function detectLang()
    {
        global  $_SERVER;
        //      if (!empty($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
        if (Request::hasVar('HTTP_ACCEPT_LANGUAGE', 'SERVER')) {
          Severity: Minor
          Found in class/Utility.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getByName has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getByName($name, $isBase = false)
    {
        $array = [];
        $lang  = null;
        if (empty($name) || \preg_match('/[^a-zA-Z0-9\_\-]/', $name)) {
          Severity: Minor
          Found in class/LanguageHandler.php - About 1 hr to fix

            Function rrmdir has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function rrmdir($src)
    {
        // Only continue if user is a 'global' Admin
        if (!($GLOBALS['xoopsUser'] instanceof XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
            return false;
            Severity: Minor
            Found in class/Common/FilesManagement.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php
// $Id: blocks.php,v 1.1.1.3 2004/11/08 03:40:00 phppp Exp $
// Blocks
define('_MB_XLANGUAGE_SELECT', '點擊以選擇您的語言');
define('_MB_XLANGUAGE_DISPLAY_METHOD', '顯示方式');
            Severity: Major
            Found in language/tchinese_utf8/blocks.php and 1 other location - About 1 hr to fix
            language/english/blocks.php on lines 1..11

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php
//
// Blocks
define('_MB_XLANGUAGE_SELECT', 'Click to select your language');
define('_MB_XLANGUAGE_DISPLAY_METHOD', 'Display method');
            Severity: Major
            Found in language/english/blocks.php and 1 other location - About 1 hr to fix
            language/tchinese_utf8/blocks.php on lines 1..12

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method xoops_module_install_xlanguage has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function xoops_module_install_xlanguage(\XoopsModule $module)
{
    require_once \dirname(__DIR__, 3) . '/mainfile.php';

    $moduleDirName = \basename(\dirname(__DIR__));
            Severity: Minor
            Found in include/oninstall.php - About 1 hr to fix

              Method loadTableFromArrayWithReplace has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function loadTableFromArrayWithReplace($table, $data, $search, $replace)
{
    /** @var \XoopsMySQLDatabase $db */
    $db = \XoopsDatabaseFactory::getDatabaseConnection();
              Severity: Minor
              Found in testdata/index.php - About 1 hr to fix

                Method prepareVars has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function prepareVars()
    {
        foreach ($this->vars as $k => $v) {
            $cleanv = $this->cleanVars[$k];
            switch ($v['data_type']) {
                Severity: Minor
                Found in class/Blanguage.php - About 1 hr to fix

                  Avoid using undefined variables such as '$skipColumns' which will lead to PHP notices.
                  Open

                      $skipColumns[] = 'gperm_id';
                  Severity: Minor
                  Found in testdata/index.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$available_languages' which will lead to PHP notices.
                  Open

                              $xoops_lang = isset($available_languages[$lang][1])?:'';
                  Severity: Minor
                  Found in class/Utility.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Severity
                  Category
                  Status
                  Source
                  Language