XoopsModules25x/xoopspoll

View on GitHub

Showing 2,846 of 2,846 total issues

The variable $xp_config is not named in camelCase.
Open

    public function assignResults(\XoopsTpl $tpl): void
    {
        $myts             = \MyTextSanitizer::getInstance();
        $xuEndTimestamp   = \xoops_getUserTimestamp($this->pollObj->getVar('end_time'));
        $xuEndFormatted   = \ucfirst(\date(_MEDIUMDATESTRING, (int)$xuEndTimestamp));
Severity: Minor
Found in class/Renderer.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $subscribe_from is not named in camelCase.
Open

    public function item(string $subscribe_from)
    {
        xoops_load('XoopsRequest');
        $poll_id = XoopsRequest::getInt('poll_id', 0);
        switch ($subscribe_from) {
Severity: Minor
Found in class/plugin/userlog.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $xp_module is not named in camelCase.
Open

    public function assignResults(\XoopsTpl $tpl): void
    {
        $myts             = \MyTextSanitizer::getInstance();
        $xuEndTimestamp   = \xoops_getUserTimestamp($this->pollObj->getVar('end_time'));
        $xuEndFormatted   = \ucfirst(\date(_MEDIUMDATESTRING, (int)$xuEndTimestamp));
Severity: Minor
Found in class/Renderer.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method _delete is not named in camelCase.
Open

    private function _delete($post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _delete is not named in camelCase.
Open

    public function _delete($post, $force = false)
    {
        global $xoopsModule;

        if (!is_object($post) || 0 == $post->getVar('post_id')) {

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

TODO found
Open

    // TODO: cleaning up and merge with post hanldings in viewpost.php

TODO found
Open

                //@TODO: add error check here

TODO found
Open

                /*@TODO::  Change block templates to use Smarty html_options to support this... then comment
Severity: Minor
Found in blocks/singlepoll.php by fixme

TODO found
Open

                //@TODO: test replacement of XoopsTree with XoopsObjectTree

TODO found
Open

        TODO if you want to use the render code below,
Severity: Minor
Found in class/Common/Breadcrumb.php by fixme

TODO found
Open

    // attachment functions    TODO: there should be a file/attachment management class

TODO found
Open

     * TODO: combining viewtopic.php

TODO found
Open

     * @TODO: Refactor to consider HTML5 & void (self-closing) elements
Severity: Minor
Found in class/Common/SysUtility.php by fixme

TODO found
Open

                \curl_setopt($curlHandle, \CURLOPT_SSL_VERIFYPEER, true); //TODO: how to avoid an error when 'Peer's Certificate issuer is not recognized'
Severity: Minor
Found in class/Common/VersionChecks.php by fixme

HACK found
Open

        //        $votedPolls = [];  //TESTING HACK TO BYPASS COOKIES
Severity: Minor
Found in class/LogHandler.php by fixme

TODO found
Open

        //TODO Parameter '$voterGrps' type is not compatible with declaration
Severity: Minor
Found in class/LogHandler.php by fixme

TODO found
Open

TODO: Planned features in the future
Severity: Minor
Found in docs/todo.txt by fixme

TODO found
Open

                //@TODO: add error checking here

TODO found
Open

     * @TODO need to exit more gracefully on error. Should throw/trigger error and then return false
Severity: Minor
Found in class/Common/SysUtility.php by fixme

TODO found
Open

    // attachment functions    TODO: there should be a file/attachment management class
Severity
Category
Status
Source
Language