Sign upLogin

aaronhipple/sampler

View on GitHub
Star

Showing 1 of 2 total issues

Avoid using AaronHipple\Sampler\count() function in while loops.
Open

        while (empty($this->fileSamples) && ++$this->fileIndex < count($this->files)) {
            $this->setFileSamples();
        }
Severity: Minor
Found in src/SampleIterator.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Severity
Category
Status
Source
Language