cloudflare_ddns/cli.py
The input method in Python 2 will read from standard input, evaluate and run the resulting string as python source code. This is similar, though in many ways worse, then using eval. On Python 2, use raw_input instead, input is safe in Python 3. Open
Open
settings["domains"][domain_to_remove] = input(
f"enter new value for domain {settings['domains'][domain_to_remove]}: "
- Create a ticketCreate a ticket
- Exclude checks
Function main
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Invalid
Invalid
def main():
"""pareser arguments"""
parser = argparse.ArgumentParser(prog="cloudflare-ddns")
parser.add_argument(
"--gensettings",
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function gen_settings
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Invalid
Invalid
def gen_settings(path):
"""
genrate settings.yml
Args:
path(str): path to settings.yml
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"