Sign upLogin

aensley/media-organizer

View on GitHub
Star

Showing 12 of 12 total issues

Function organize has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function organize($profiles = array())
    {
        if (empty($profiles)) {
            $profiles = $this->profiles;
        }
Severity: Minor
Found in src/Aensley/MediaOrganizer/MediaOrganizer.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class MediaOrganizer has an overall complexity of 77 which is very high. The configured complexity threshold is 50.
Open

class MediaOrganizer
{

    /**
     * Default profile settings. Override in individual profiles.
Severity: Minor
Found in src/Aensley/MediaOrganizer/MediaOrganizer.php by phpmd

File MediaOrganizer.php has 268 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Aensley\MediaOrganizer;

/**
Severity: Minor
Found in src/Aensley/MediaOrganizer/MediaOrganizer.php - About 2 hrs to fix

    Function listFiles has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        private function listFiles($directory)
    {
        $returnFiles = array();
        $files = scandir($directory);
        foreach ($files as $file) {
    Severity: Minor
    Found in src/Aensley/MediaOrganizer/MediaOrganizer.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method organize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function organize($profiles = array())
    {
        if (empty($profiles)) {
            $profiles = $this->profiles;
        }
    Severity: Minor
    Found in src/Aensley/MediaOrganizer/MediaOrganizer.php - About 1 hr to fix

      Method moveFile has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function moveFile($file = '', $date = '')
    {
        $extension = pathinfo($file, PATHINFO_EXTENSION);
        // Keep file name short enough to allow for up to 9,999 of the same file name without collision.
        $filename = substr(pathinfo($file, PATHINFO_FILENAME), 0, (255 - (strlen($extension) + 6)));
      Severity: Minor
      Found in src/Aensley/MediaOrganizer/MediaOrganizer.php - About 1 hr to fix

        Function getExifDate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getExifDate($file = '')
    {
        $exif = @exif_read_data($file, 'EXIF');
        // Fields in which to find the date, in order of preference.
        $exifFields = array('DateTime', 'DateTimeOriginal', 'DateTimeDigitized');
        Severity: Minor
        Found in src/Aensley/MediaOrganizer/MediaOrganizer.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getDate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getDate($file = '')
    {
        if ($this->options['scan_exif']) {
            $date = $this->getExifDate($file);
            if ($date) {
        Severity: Minor
        Found in src/Aensley/MediaOrganizer/MediaOrganizer.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in src/Aensley/MediaOrganizer/MediaOrganizer.php - About 30 mins to fix

          Remove error control operator '@' on line 349.
          Open

              private function getExifDate($file = '')
    {
        $exif = @exif_read_data($file, 'EXIF');
        // Fields in which to find the date, in order of preference.
        $exifFields = array('DateTime', 'DateTimeOriginal', 'DateTimeDigitized');
          Severity: Minor
          Found in src/Aensley/MediaOrganizer/MediaOrganizer.php by phpmd

          ErrorControlOperator

          Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

          Example

          function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

          Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

          Function moveFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function moveFile($file = '', $date = '')
    {
        $extension = pathinfo($file, PATHINFO_EXTENSION);
        // Keep file name short enough to allow for up to 9,999 of the same file name without collision.
        $filename = substr(pathinfo($file, PATHINFO_FILENAME), 0, (255 - (strlen($extension) + 6)));
          Severity: Minor
          Found in src/Aensley/MediaOrganizer/MediaOrganizer.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method organize() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
          Open

              public function organize($profiles = array())
    {
        if (empty($profiles)) {
            $profiles = $this->profiles;
        }
          Severity: Minor
          Found in src/Aensley/MediaOrganizer/MediaOrganizer.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Severity
          Category
          Status
          Source
          Language