Showing 1,051 of 1,052 total issues
Avoid deeply nested control flow statements. Open
Open
if logger.IsDebugEnabled() {
logger.Debug().Msg("stop gathering tx due to size limit")
}Method AergoRPCService.GetBlock has 7 return statements (exceeds 4 allowed). Open
Open
func (rpc *AergoRPCService) GetBlock(ctx context.Context, in *types.SingleBytes) (*types.Block, error) {
if err := rpc.checkAuth(ctx, ReadBlockChain); err != nil {
return nil, err
}
var result interface{}Method getHashRequestHandler.Handle has 7 return statements (exceeds 4 allowed). Open
Open
func (bh *getHashRequestHandler) Handle(msg p2pcommon.Message, msgBody p2pcommon.MessageBody) {
remotePeer := bh.peer
data := msgBody.(*types.GetHashesRequest)
p2putil.DebugLogReceive(bh.logger, bh.protocol, msg.ID().String(), remotePeer, data)
chainAccessor := bh.actor.GetChainAccessor()Avoid deeply nested control flow statements. Open
Open
if err != nil {
mp.Warn().Err(err).Msg("failed to init whitelist")
}Avoid deeply nested control flow statements. Open
Open
if err != nil {
mp.Warn().Err(err).Msg("failed to get whitelist")
}Method MemPool.getUnconfirmed has 7 return statements (exceeds 4 allowed). Open
Open
func (mp *MemPool) getUnconfirmed(accounts []types.Address, countOnly bool) []*unconfirmedTxs {
mp.RLock()
defer mp.RUnlock()
getTxList := func(acc types.Address) (*txList, *time.Time) {Method WalDB.ReadAll has 7 return statements (exceeds 4 allowed). Open
Open
func (wal *WalDB) ReadAll(snapshot *raftpb.Snapshot) (id *consensus.RaftIdentity, state *raftpb.HardState, ents []raftpb.Entry, err error) {
if id, err = wal.GetIdentity(); err != nil {
return nil, state, ents, err
}
Method V030ReadWriter.WriteMsg has 7 return statements (exceeds 4 allowed). Open
Open
func (rw *V030ReadWriter) WriteMsg(msg p2pcommon.Message) error {
writeN := 0
if msg.Length() != uint32(len(msg.Payload())) {
return fmt.Errorf("Invalid payload size")
}Avoid deeply nested control flow statements. Open
Open
} else if err != nil {
logger.Info().Err(err).Msg("failed to produce block")
continue
}Avoid deeply nested control flow statements. Open
Open
if i == start {
err = futureErr
}Method BlocksChunkReceiver.handleInWaiting has 7 return statements (exceeds 4 allowed). Open
Open
func (br *BlocksChunkReceiver) handleInWaiting(msg p2pcommon.Message, msgBody p2pcommon.MessageBody) {
// consuming request id when timeout, no more resp expected (i.e. hasNext == false ) or malformed body.
// timeout
if br.timeout.Before(time.Now()) {
// silently ignore already status jobAvoid deeply nested control flow statements. Open
Open
} else if err != nil {
logger.Debug().Err(err).Int("idx", i).Stringer("hash", types.LogBase58(tx.GetHash())).Msg("skip error tx")
//FIXME handling system error (panic?)
// ex) gas error/nonce error skip, but other system error panicMethod raftServer.GetClusterProgress has 7 return statements (exceeds 4 allowed). Open
Open
func (rs *raftServer) GetClusterProgress() (*ClusterProgress, error) {
getProgressState := func(raftProgress *raftlib.Progress, lastLeaderIndex uint64, nodeID uint64, leadID uint64) MemberProgressState {
isLeader := nodeID == leadID
if !isLeader {Method BlockFactory.controller has 7 return statements (exceeds 4 allowed). Open
Open
func (bf *BlockFactory) controller() {
defer shutdownMsg("block factory controller")
beginBlock := func(bpi *bpInfo) error {
// This is only for draining an unconsumed message, which meansMethod OutboundWireHandshaker.handleOutboundPeer has 7 return statements (exceeds 4 allowed). Open
Open
func (h *OutboundWireHandshaker) handleOutboundPeer(ctx context.Context, rwc io.ReadWriteCloser) (*p2pcommon.HandshakeResult, error) {
// send initial hs message
versions := p2pcommon.AttemptingOutboundVersions
hsHeader := p2pcommon.HSHeadReq{Magic: p2pcommon.MAGICMain, Versions: versions}Method Cluster.ChangeMembership has 7 return statements (exceeds 4 allowed). Open
Open
func (cl *Cluster) ChangeMembership(req *types.MembershipChange, nowait bool) (*consensus.Member, error) {
var (
proposal *consensus.ConfChangePropose
err error
)Avoid deeply nested control flow statements. Open
Open
if i == end {
err = futureErr
}Avoid deeply nested control flow statements. Open
Open
if e.JsonArgs == "true" {
value = true
}Avoid deeply nested control flow statements. Open
Open
} else if conf == enterprise.AccountWhite {
value := false
if e.JsonArgs == "true" {
value = true
}Method Web3APIv1.GetVotes has 7 return statements (exceeds 4 allowed). Open
Open
func (api *Web3APIv1) GetVotes() (handler http.Handler, ok bool) {
values, err := url.ParseQuery(api.request.URL.RawQuery)
if err != nil {
return commonResponseHandler(&types.Empty{}, err), true
}