Sign upLogin

aergoio/aergo

View on GitHub
Star

Showing 1,051 of 1,052 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ctx.traceFile != nil {
            _, _ = ctx.traceFile.WriteString(fmt.Sprintf("[error] : %s\n", err))
            _, _ = ctx.traceFile.WriteString(fmt.Sprintf("[usedFee] : %s\n", ctx.usedFee().String()))
            events := ce.getEvents()
            if events != nil {
Severity: Major
Found in contract/vm.go and 1 other location - About 2 hrs to fix
contract/vm.go on lines 834..848

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 221.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ctx.traceFile != nil {
            _, _ = ctx.traceFile.WriteString(fmt.Sprintf("[error] : %s\n", err))
            _, _ = ctx.traceFile.WriteString(fmt.Sprintf("[usedFee] : %s\n", ctx.usedFee().String()))
            events := ce.getEvents()
            if events != nil {
Severity: Major
Found in contract/vm.go and 1 other location - About 2 hrs to fix
contract/vm.go on lines 979..993

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 221.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

MockNetworkTransport has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

type MockNetworkTransport struct {
    ctrl     *gomock.Controller
    recorder *MockNetworkTransportMockRecorder
}
Severity: Minor
Found in p2p/p2pmock/mock_networktransport.go - About 2 hrs to fix

    SQLiteConn has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type SQLiteConn struct {
    mu          sync.Mutex
    db          *C.sqlite3
    loc         *time.Location
    txlock      string
    Severity: Minor
    Found in contract/sqlite3.go - About 2 hrs to fix

      Method raftServer.publishEntries has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
      Open

      func (rs *raftServer) publishEntries(ents []raftpb.Entry) bool {
    var lastBlockEnt *raftpb.Entry

    isDuplicateCommit := func(block *types.Block) bool {
        lastReq := rs.commitProgress.GetRequest()
      Severity: Minor
      Found in consensus/impl/raftv2/raftserver.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method raftServer.startRaft has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
      Open

      func (rs *raftServer) startRaft() {
    var node raftlib.Node

    getState := func() RaftServerState {
        hasWal, err := rs.walDB.HasWal(rs.cluster.identity)
      Severity: Minor
      Found in consensus/impl/raftv2/raftserver.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method transaction.Validate has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
      Open

      func (tx *transaction) Validate(chainidhash []byte, isPublic bool) error {
    if tx.GetTx() == nil || tx.GetTx().GetBody() == nil {
        return ErrTxFormatInvalid
    }
      Severity: Minor
      Found in types/transaction.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File blockchain.go has 517 lines of code (exceeds 500 allowed). Consider refactoring.
      Open

      /**
 *  @file
 *  @copyright defined in aergo/LICENSE.txt
 */
      Severity: Minor
      Found in types/blockchain.go - About 2 hrs to fix

        Method SQLiteRows.Next has 85 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (rc *SQLiteRows) Next(dest []driver.Value) error {
    rc.s.mu.Lock()
    defer rc.s.mu.Unlock()
    if rc.s.closed {
        return io.EOF
        Severity: Major
        Found in contract/sqlite3.go - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (c *vprCmd) subVpr(v *types.Vote) {
    no := c.BlockInfo.No
    aid := c.Sender.AccountID()

    // Handle exception 1. multisig contract ( AmhNcvE7RR84xoRzYNyATnwZR2JXaC5ut7neu89R13aj1b4eUxKp )
          Severity: Major
          Found in contract/system/vote.go and 1 other location - About 2 hrs to fix
          contract/system/vote.go on lines 113..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 213.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (c *vprCmd) addVpr(v *types.Vote) {
    no := c.BlockInfo.No
    aid := c.Sender.AccountID()

    // Handle exception 1. multisig contract ( AmhNcvE7RR84xoRzYNyATnwZR2JXaC5ut7neu89R13aj1b4eUxKp )
          Severity: Major
          Found in contract/system/vote.go and 1 other location - About 2 hrs to fix
          contract/system/vote.go on lines 90..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 213.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method batch.Run has 84 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (c *batch) Run(args string) (string, uint64, []*types.Event, error) {
    stdOut := colorable.NewColorableStdout()

    var err error
          Severity: Major
          Found in cmd/brick/exec/batch.go - About 2 hrs to fix

            Function runDeployCmd has 84 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func runDeployCmd(cmd *cobra.Command, args []string) error {
    var err error
    var code []byte
    var deployArgs []byte
            Severity: Major
            Found in cmd/aergocli/cmd/contract.go - About 2 hrs to fix

              File vm_direct.go has 515 lines of code (exceeds 500 allowed). Consider refactoring.
              Open

              package vm_direct

import (
    "bytes"
    "context"
              Severity: Minor
              Found in contract/vm_direct/vm_direct.go - About 2 hrs to fix

                MockNetworkTransportMockRecorder has 22 methods (exceeds 20 allowed). Consider refactoring.
                Open

                type MockNetworkTransportMockRecorder struct {
    mock *MockNetworkTransport
}
                Severity: Minor
                Found in p2p/p2pmock/mock_networktransport.go - About 2 hrs to fix

                  DPoS has 22 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  type DPoS struct {
    *Status
    consensus.ChainDB
    *component.ComponentHub
    bpc  *bp.Cluster
                  Severity: Minor
                  Found in consensus/impl/dpos/dpos.go - About 2 hrs to fix

                    PeerMapService has 22 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    type PeerMapService struct {
    *component.BaseComponent

    PrivateNet   bool
    allowPrivate bool
                    Severity: Minor
                    Found in cmd/polaris/server/mapservice.go - About 2 hrs to fix

                      AccountState has 22 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                      type AccountState struct {
    sdb      *statedb.StateDB
    id       []byte
    aid      types.AccountID
    oldState *types.State
                      Severity: Minor
                      Found in state/account.go - About 2 hrs to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        func (rpc *AergoRPCService) GetABI(ctx context.Context, in *types.SingleBytes) (*types.ABI, error) {
    if err := rpc.checkAuth(ctx, ReadBlockChain); err != nil {
        return nil, err
    }
    result, err := rpc.hub.RequestFuture(message.ChainSvc,
                        Severity: Major
                        Found in rpc/grpcserver.go and 1 other location - About 2 hrs to fix
                        rpc/grpcserver.go on lines 1054..1068

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 208.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        func (rpc *AergoRPCService) GetReceipt(ctx context.Context, in *types.SingleBytes) (*types.Receipt, error) {
    if err := rpc.checkAuth(ctx, ReadBlockChain); err != nil {
        return nil, err
    }
    result, err := rpc.hub.RequestFuture(message.ChainSvc,
                        Severity: Major
                        Found in rpc/grpcserver.go and 1 other location - About 2 hrs to fix
                        rpc/grpcserver.go on lines 1148..1162

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 208.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language