Sign upLogin

af83/chouette-core

View on GitHub
Star
app/helpers/table_builder_helper.rb

Summary

Maintainability
F
4 days
Test Coverage

Method tr has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
Open

  def tr item, columns, selectable, links, overhead, model_name, action
    klass = "#{model_name} #{model_name}-#{item.id}"
    content_tag :tr, class: klass do
      bcont = []
      if selectable
Severity: Minor
Found in app/helpers/table_builder_helper.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method thead has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

  def thead(collection, columns, sortable, selectable, has_links, overhead, model, action)
    content_tag :thead do
      # Inserts overhead content if any specified
      over_head = ''
Severity: Minor
Found in app/helpers/table_builder_helper.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File table_builder_helper.rb has 293 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'table_builder_helper/column'
require 'table_builder_helper/url'

# table_builder_2
# A Rails helper that constructs an HTML table from a collection of objects. It
Severity: Minor
Found in app/helpers/table_builder_helper.rb - About 3 hrs to fix

    Method thead has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def thead(collection, columns, sortable, selectable, has_links, overhead, model, action)
    content_tag :thead do
      # Inserts overhead content if any specified
      over_head = ''
    Severity: Major
    Found in app/helpers/table_builder_helper.rb - About 2 hrs to fix

      Method tr has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def tr item, columns, selectable, links, overhead, model_name, action
    klass = "#{model_name} #{model_name}-#{item.id}"
    content_tag :tr, class: klass do
      bcont = []
      if selectable
      Severity: Major
      Found in app/helpers/table_builder_helper.rb - About 2 hrs to fix

        Method build_column_header has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def build_column_header(
        column,
        table_is_sortable,
        model,
        params
        Severity: Minor
        Found in app/helpers/table_builder_helper.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method build_column_header has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def build_column_header(
        column,
        table_is_sortable,
        model,
        params
        Severity: Minor
        Found in app/helpers/table_builder_helper.rb - About 1 hr to fix

          Method gear_menu_link has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def gear_menu_link(link)
    klass = []
    klass << link.extra_class if link.extra_class
    klass << 'delete-action' if link.method == :delete
    klass << 'disabled' if link.disabled
          Severity: Minor
          Found in app/helpers/table_builder_helper.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method thead has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def thead(collection, columns, sortable, selectable, has_links, overhead, model, action)
          Severity: Major
          Found in app/helpers/table_builder_helper.rb - About 1 hr to fix

            Method tbody has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def tbody(collection, columns, selectable, links, overhead, model = nil, action)
            Severity: Major
            Found in app/helpers/table_builder_helper.rb - About 50 mins to fix

              Method tr has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def tr item, columns, selectable, links, overhead, model_name, action
              Severity: Major
              Found in app/helpers/table_builder_helper.rb - About 50 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                  if (j + o[:width].to_i) >= i
                    prev = o
                    break
                  end
                Severity: Major
                Found in app/helpers/table_builder_helper.rb - About 45 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                if i > 0
                (i-1..0).each do |j|
                  o = overhead[j]
                  if (j + o[:width].to_i) >= i
                    prev = o
                  Severity: Minor
                  Found in app/helpers/table_builder_helper.rb and 1 other location - About 25 mins to fix
                  app/helpers/table_builder_helper.rb on lines 154..160

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 30.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                if i > 0
                (i-1..0).each do |j|
                  o = overhead[j]
                  if (j + o[:width].to_i) >= i
                    prev = o
                  Severity: Minor
                  Found in app/helpers/table_builder_helper.rb and 1 other location - About 25 mins to fix
                  app/helpers/table_builder_helper.rb on lines 239..245

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 30.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status