Sign upLogin

af83/chouette-core

View on GitHub
Star
app/lib/chouette/transport_mode.rb

Summary

Maintainability
B
5 hrs
Test Coverage

File transport_mode.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Chouette
  class TransportMode
    attr_reader :mode, :sub_mode

    def initialize(mode, sub_mode = nil)
Severity: Minor
Found in app/lib/chouette/transport_mode.rb - About 2 hrs to fix

    Class TransportMode has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class TransportMode
    attr_reader :mode, :sub_mode

    def initialize(mode, sub_mode = nil)
      @mode = mode&.to_sym
    Severity: Minor
    Found in app/lib/chouette/transport_mode.rb - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def human_name(locale: I18n.locale, separator: ' / ')
      return unless valid?

      [].tap do |parts|
        parts << mode_human_name(locale: locale)
      Severity: Minor
      Found in app/lib/chouette/transport_mode.rb and 1 other location - About 25 mins to fix
      app/lib/chouette/service_facility.rb on lines 21..27

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status