Sign upLogin

af83/chouette-core

View on GitHub
Star
app/models/chouette/stop_area.rb

Summary

Maintainability
F
3 days
Test Coverage

Class StopArea has 76 methods (exceeds 20 allowed). Consider refactoring.
Open

  class StopArea < Chouette::ActiveRecord
    include StopAreaReferentialSupport

    has_metadata
    include ProjectionFields
Severity: Major
Found in app/models/chouette/stop_area.rb - About 1 day to fix

    File stop_area.rb has 537 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'geokit'
require 'geo_ruby'
module Chouette
  class StopArea < Chouette::ActiveRecord
    include StopAreaReferentialSupport
    Severity: Major
    Found in app/models/chouette/stop_area.rb - About 1 day to fix

      Method average_bearings has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

            def average_bearings(options={})
        options_ = options.dup
        options_[:limit] = 5000 unless options_[:limit]
        options_[:page] = 1 unless options_[:page]
        options_[:debug_mode] = false
      Severity: Minor
      Found in app/models/chouette/stop_area.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method compute_bearings has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def compute_bearings(options={})
        query = <<~TEXT
          SELECT
            stop_area_id, AVG(bearing) AS avg_bearing
          FROM (
      Severity: Minor
      Found in app/models/chouette/stop_area.rb - About 1 hr to fix

        Method registration_number_is_set has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def registration_number_is_set
      return unless stop_area_referential&.registration_number_format.present?

      unless registration_number.present?
        errors.add(:registration_number, I18n.t('stop_areas.errors.registration_number.cannot_be_empty'))
        Severity: Minor
        Found in app/models/chouette/stop_area.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def closest_children
      return self.children if position.blank?

      parent_point = self.class.connection.quote("SRID=4326;POINT(#{longitude} #{latitude})")
      child_point   = "ST_SetSRID(ST_MakePoint(longitude, latitude), 4326)"
        Severity: Minor
        Found in app/models/chouette/stop_area.rb and 1 other location - About 45 mins to fix
        app/models/chouette/stop_area.rb on lines 276..282

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def closest_specific_stops
      return self.specific_stops if position.blank?

      parent_point = self.class.connection.quote("SRID=4326;POINT(#{longitude} #{latitude})")
      specific_point   = "ST_SetSRID(ST_MakePoint(longitude, latitude), 4326)"
        Severity: Minor
        Found in app/models/chouette/stop_area.rb and 1 other location - About 45 mins to fix
        app/models/chouette/stop_area.rb on lines 267..273

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status