Sign upLogin

af83/chouette-core

View on GitHub
Star
app/models/export/gtfs.rb

Summary

Maintainability
F
4 days
Test Coverage

File gtfs.rb has 1267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Export::Gtfs < Export::Base
  include LocalExportSupport

  option :period, default_value: 'all_periods', enumerize: %w[all_periods only_next_days static_day_period]
  option :duration
Severity: Major
Found in app/models/export/gtfs.rb - About 3 days to fix

    Class Index has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Index

    def initialize
      @stop_ids = {}
      @route_ids = {}
    Severity: Minor
    Found in app/models/export/gtfs.rb - About 2 hrs to fix

      Method route_type has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

            def route_type
        unless flexible_service
          return 103 if transport_mode == 'rail' && transport_submode == 'interregionalRail'
          return 204 if transport_mode == 'coach' && transport_submode == 'regionalCoach'
          return 205 if transport_mode == 'coach' && transport_submode == 'specialCoach'
      Severity: Minor
      Found in app/models/export/gtfs.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def initialize(stop_area, index = nil, public_code_space = "", duplicated_registration_numbers = [], code_space = nil)
      Severity: Minor
      Found in app/models/export/gtfs.rb - About 35 mins to fix

        Method export! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def export!
      lines.includes(:referent).find_each do |line|
        exported_line = (prefer_referent_line ? line.referent : line) || line
        decorated_line = Decorator.new(exported_line, index, duplicated_registration_numbers)
        Severity: Minor
        Found in app/models/export/gtfs.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                  return 713 if transport_mode == 'bus' && transport_submode == 'schoolAndPublicServiceBus'
        Severity: Major
        Found in app/models/export/gtfs.rb - About 30 mins to fix

          Method company_ids has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def company_ids
      ids = Set.new
      # OPTIMIZEME pluck is great bu can consume a lot of memory for very large Vehicle Journey collection
      vehicle_journeys.left_joins(route: { line: :company }).
        pluck("vehicle_journeys.id", "companies.id", "companies.time_zone").
          Severity: Minor
          Found in app/models/export/gtfs.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def ensure_is_valid_period
    return unless period == 'static_day_period'

    if from.blank? || to.blank? || from > to
      errors.add(:from, :invalid)
          Severity: Minor
          Found in app/models/export/gtfs.rb and 1 other location - About 15 mins to fix
          app/models/export/netex_generic.rb on lines 16..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status