Sign upLogin

af83/chouette-core

View on GitHub
Star
app/models/import/neptune.rb

Summary

Maintainability
F
3 days
Test Coverage

File neptune.rb has 427 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Import::Neptune < Import::Base
  include LocalImportSupport

  def self.accepts_file?(file)
    ::Neptune::Source.accept?(file)
Severity: Minor
Found in app/models/import/neptune.rb - About 6 hrs to fix

    Method import_stop_areas has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

      def import_stop_areas
    @parent_stop_areas = {}
    stop_area_registration_numbers = Set.new

    each_element_matching_css('ChouettePTNetwork ChouetteArea') do |source_parent, _, progress|
    Severity: Minor
    Found in app/models/import/neptune.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Neptune has 35 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Import::Neptune < Import::Base
  include LocalImportSupport

  def self.accepts_file?(file)
    ::Neptune::Source.accept?(file)
    Severity: Minor
    Found in app/models/import/neptune.rb - About 4 hrs to fix

      Method import_lines has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

        def import_lines
    each_element_matching_css('ChouettePTNetwork') do |source_pt_network, filename, progress|
      file_company = get_associated_company(source_pt_network, filename)
      file_network = get_associated_network(source_pt_network, filename)
      Severity: Minor
      Found in app/models/import/neptune.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import_stop_areas has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def import_stop_areas
    @parent_stop_areas = {}
    stop_area_registration_numbers = Set.new

    each_element_matching_css('ChouettePTNetwork ChouetteArea') do |source_parent, _, progress|
      Severity: Minor
      Found in app/models/import/neptune.rb - About 1 hr to fix

        Method build_object_from_nokogiri_element has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def build_object_from_nokogiri_element(element)
    out = { _node: element }
    element.elements.each do |child|
      key = child.name.underscore.to_sym
        Severity: Minor
        Found in app/models/import/neptune.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method int_day_types_mapping has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def int_day_types_mapping day_types
    day_types = make_enum day_types

    val = 0
    day_types.each do |day_type|
        Severity: Minor
        Found in app/models/import/neptune.rb - About 1 hr to fix

          Method import_vehicle_journeys_in_line has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def import_vehicle_journeys_in_line(line, source_vehicle_journeys)
    source_vehicle_journeys = make_enum source_vehicle_journeys

    source_vehicle_journeys.each do |source_vehicle_journey|
      if source_vehicle_journey[:journey_pattern_id]
          Severity: Minor
          Found in app/models/import/neptune.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def get_associated_company(source_pt_network, filename)
    company = nil
    each_element_matching_css('Company', source_pt_network) do |source_company, filename, progress|
      if company
        create_message(
          Severity: Minor
          Found in app/models/import/neptune.rb and 1 other location - About 30 mins to fix
          app/models/import/neptune.rb on lines 68..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def get_associated_network(source_pt_network, filename)
    network = nil
    each_element_matching_css('PTNetwork', source_pt_network) do |source_network, filename, progress|
      if network
        create_message(
          Severity: Minor
          Found in app/models/import/neptune.rb and 1 other location - About 30 mins to fix
          app/models/import/neptune.rb on lines 84..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status