Sign upLogin

af83/chouette-core

View on GitHub
Star
app/models/import/workbench.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Workbench has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class Import::Workbench < Import::Base
  include ImportResourcesSupport

  after_commit :launch_worker, :on => :create
Severity: Minor
Found in app/models/import/workbench.rb - About 2 hrs to fix

    Method compute_new_status has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def compute_new_status
    if control_list_runs.present? || macro_list_runs.present?
      if children_status == 'running' || processed_status == 'running'
        return 'running'
      elsif children_status == 'failed' || processed_status == 'failed'
    Severity: Minor
    Found in app/models/import/workbench.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return children_status
    Severity: Major
    Found in app/models/import/workbench.rb - About 30 mins to fix

      Method done! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def done! successful
    if successful
      flag_refentials_as_urgent if flag_urgent
      create_automatic_merge if automatic_merge
    else
      Severity: Minor
      Found in app/models/import/workbench.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status