Sign upLogin

af83/chouette-core

View on GitHub
Star
app/models/merge/referential/legacy.rb

Summary

Maintainability
F
1 wk
Test Coverage

Method merge! has a Cognitive Complexity of 260 (exceeds 5 allowed). Consider refactoring.
Open

  def merge!
    logger.tagged("Merge ##{merge.id}") do
      referential.switch do
        Chouette::ChecksumUpdater.new(referential).update
      end
Severity: Minor
Found in app/models/merge/referential/legacy.rb - About 5 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method merge! has 282 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def merge!
    logger.tagged("Merge ##{merge.id}") do
      referential.switch do
        Chouette::ChecksumUpdater.new(referential).update
      end
Severity: Major
Found in app/models/merge/referential/legacy.rb - About 1 day to fix

    File legacy.rb has 434 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Merge::Referential::Legacy < Merge::Referential::Base

  def merge_metadata
    metadata_merger = Merge::Referential::MetadatasMerger.new new, referential
    metadata_merger.merge
    Severity: Minor
    Found in app/models/merge/referential/legacy.rb - About 6 hrs to fix

      Method legacy_merge_vehicle_journeys has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def legacy_merge_vehicle_journeys(referential_vehicle_journeys)
    referential_vehicle_journey_footnote_checksums = {}
    referential_vehicle_journey_codes = Hash.new { |h,k| h[k] = [] }

    referential.switch do
      Severity: Major
      Found in app/models/merge/referential/legacy.rb - About 2 hrs to fix

        Method legacy_merge_vehicle_journeys has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def legacy_merge_vehicle_journeys(referential_vehicle_journeys)
    referential_vehicle_journey_footnote_checksums = {}
    referential_vehicle_journey_codes = Hash.new { |h,k| h[k] = [] }

    referential.switch do
        Severity: Minor
        Found in app/models/merge/referential/legacy.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                if new_route.checksum != route.checksum
                          raise "Checksum has changed for route #{route.id}:\n \"#{route.checksum}\", \"#{route.checksum_source}\" \n -> \n \"#{new_route.checksum}\", \"#{new_route.checksum_source}\""
        Severity: Minor
        Found in app/models/merge/referential/legacy.rb and 1 other location - About 20 mins to fix
        app/models/merge/referential/legacy.rb on lines 308..309

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      if new_footnote.checksum != footnote.checksum
                raise "Checksum has changed for footnote #{footnote.id} :\n \"#{footnote.checksum}\", \"#{footnote.checksum_source}\" \n -> \n \"#{new_footnote.checksum}\", \"#{new_footnote.checksum_source}\""
        Severity: Minor
        Found in app/models/merge/referential/legacy.rb and 1 other location - About 20 mins to fix
        app/models/merge/referential/legacy.rb on lines 152..153

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status