Sign upLogin

af83/chouette-core

View on GitHub
Star
app/services/referential_copy.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method copy_with_inserters has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def copy_with_inserters
    source.switch do
      vehicle_journeys = source.vehicle_journeys.joins(:route).where("routes.line_id" => lines)
      time_tables = source.time_tables.joins(:vehicle_journeys).where('vehicle_journeys.id' => vehicle_journeys).distinct
Severity: Minor
Found in app/services/referential_copy.rb - About 1 hr to fix

    Method copy_route has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def copy_route route
    line = route.line
    attributes = clean_attributes_for_copy route
    opposite_route = route.opposite_route
    Severity: Minor
    Found in app/services/referential_copy.rb - About 1 hr to fix

      Method copy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def copy(raise_error: false)
    measure "copy", source: source.id, target: target.id do
      CustomFieldsSupport.within_workgroup(workgroup) do
        copy_resource(:metadatas) unless skip_metadatas?
        source.switch do
      Severity: Minor
      Found in app/services/referential_copy.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def copy_metadatas
    source.metadatas.find_each do |metadata|
      candidate = target.metadatas.with_lines(metadata.line_ids).find { |m| m.periodes == metadata.periodes }
      candidate ||= target.metadatas.build(line_ids: metadata.line_ids, periodes: metadata.periodes, referential_source: source, created_at: metadata.created_at, updated_at: metadata.created_at)
      candidate.priority = source_priority if source_priority
      Severity: Major
      Found in app/services/referential_copy.rb and 1 other location - About 1 hr to fix
      app/models/referential/copy.rb on lines 255..262

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status