af83/chouette-core

View on GitHub

Showing 922 of 922 total issues

File time_table.rb has 578 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Chouette
  class TimeTable < Referential::Model
    include ApplicationDaysSupport
    include ObjectidSupport
    include TimetableSupport
Severity: Major
Found in app/models/chouette/time_table.rb - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                <div className='form-group has_switch'>
                  <label className='control-label pull-left'>{I18n.t("vehicle_journeys.form.show_journeys_without_schedule")}</label>
                  <div className='form-group pull-left' style={{padding: 0}}>
                    <div className='checkbox'>
                      <label>
    Severity: Major
    Found in app/packs/src/vehicle_journeys/components/Filters.js and 1 other location - About 1 day to fix
    app/packs/src/vehicle_journeys/components/Filters.js on lines 150..166

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 228.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                <div className='form-group has_switch'>
                  <label className='control-label pull-left'>{I18n.t("vehicle_journeys.form.show_journeys_with_calendar")}</label>
                  <div className='form-group pull-left' style={{padding: 0}}>
                    <div className='checkbox'>
                      <label>
    Severity: Major
    Found in app/packs/src/vehicle_journeys/components/Filters.js and 1 other location - About 1 day to fix
    app/packs/src/vehicle_journeys/components/Filters.js on lines 129..145

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 228.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method attribute has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
    Open

        def attribute(attribute_name, options = {})
          resource = options[:object] || object
    
          if options.key?(:value)
            raw_value = options[:value]
    Severity: Minor
    Found in app/helpers/simple_block_for_helper.rb - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class TimeTable has 63 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class TimeTable < Referential::Model
        include ApplicationDaysSupport
        include ObjectidSupport
        include TimetableSupport
        has_metadata
    Severity: Major
    Found in app/models/chouette/time_table.rb - About 1 day to fix

      Method import_stops has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
      Open

        def import_stops
          sorted_stops = source.stops.sort_by { |s| s.parent_station.present? ? 1 : 0 }
          @stop_areas_id_by_registration_number = {}
      
          CustomFieldsSupport.within_workgroup(workbench.workgroup) do
      Severity: Minor
      Found in app/models/import/gtfs.rb - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File stop_area.rb has 537 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'geokit'
      require 'geo_ruby'
      module Chouette
        class StopArea < Chouette::ActiveRecord
          include StopAreaReferentialSupport
      Severity: Major
      Found in app/models/chouette/stop_area.rb - About 1 day to fix

        File vehicle_journey.rb has 524 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        module Chouette
          class VehicleJourney < Referential::Model
            include CustomFieldsSupport
            include TransportModeEnumerations
        
        
        Severity: Major
        Found in app/models/chouette/vehicle_journey.rb - About 1 day to fix

          File factory.rb has 511 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          module Chouette
            class Factory # rubocop:disable Metrics/ClassLength
              extend Definition
          
              define do
          Severity: Major
          Found in app/lib/chouette/factory.rb - About 1 day to fix

            File ara.rb has 508 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require 'ara/file'
            class Export::Ara < Export::Base
              include LocalExportSupport
            
              # FIXME: Should be shared
            Severity: Major
            Found in app/models/export/ara.rb - About 1 day to fix

              Function vehicleJourney has 193 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const vehicleJourney= (state = {}, action, keep) => {
                switch (action.type) {
                  case 'SELECT_VEHICLEJOURNEY':
                    return _.assign({}, state, {selected: !state.selected})
                  case 'CANCEL_SELECTION':
              Severity: Major
              Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js - About 7 hrs to fix

                File source.rb has 484 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'mimemagic_ext'
                require 'net/ftp'
                
                class Source < ApplicationModel
                  extend Enumerize
                Severity: Minor
                Found in app/models/source.rb - About 7 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    fetch_constraint_zones() {
                      if(this.fetching_constraint_zones){ return }
                      this.fetching_constraint_zones = true
                  
                      let url = window.constraint_zones_routes + ".json"
                  app/packs/src/vehicle_journeys/components/tools/ConstraintExclusionEditVehicleJourney.js on lines 79..98

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 185.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      case 'UPDATE_START_TIME_FILTER':
                        newInterval = JSON.parse(JSON.stringify(state.query.interval))
                        newInterval.start[action.unit] = actions.pad(action.val, action.unit)
                        if(parseInt(newInterval.start.hour + newInterval.start.minute) < parseInt(newInterval.end.hour + newInterval.end.minute)){
                          newQuery = _.assign({}, state.query, {interval: newInterval})
                  Severity: Major
                  Found in app/packs/src/vehicle_journeys/reducers/filters.js and 1 other location - About 7 hrs to fix
                  app/packs/src/vehicle_journeys/reducers/filters.js on lines 26..34

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 185.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    fetch_stop_area_constraints() {
                      if(this.fetching_stop_area_constraints){ return }
                      this.fetching_stop_area_constraints = true
                  
                      let url = window.stop_area_constraints_routes + ".json"
                  app/packs/src/vehicle_journeys/components/tools/ConstraintExclusionEditVehicleJourney.js on lines 58..77

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 185.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      case 'UPDATE_END_TIME_FILTER':
                        newInterval = JSON.parse(JSON.stringify(state.query.interval))
                        newInterval.end[action.unit] = actions.pad(action.val, action.unit)
                        if(parseInt(newInterval.start.hour + newInterval.start.minute) < parseInt(newInterval.end.hour + newInterval.end.minute)){
                          newQuery = _.assign({}, state.query, {interval: newInterval})
                  Severity: Major
                  Found in app/packs/src/vehicle_journeys/reducers/filters.js and 1 other location - About 7 hrs to fix
                  app/packs/src/vehicle_journeys/reducers/filters.js on lines 35..43

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 185.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method thead has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def thead(collection, columns, sortable, selectable, has_links, overhead, model, action)
                      content_tag :thead do
                        # Inserts overhead content if any specified
                        over_head = ''
                  
                  
                  Severity: Minor
                  Found in app/helpers/table_builder_helper.rb - About 7 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function render has 182 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    render() {
                      let fetched = true
                      if(this.constraint_zones === null) {
                        this.fetch_constraint_zones()
                        fetched = false

                    File legacy.rb has 462 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    class Merge::Referential::Legacy < Merge::Referential::Base
                    
                      def merge_metadata
                        metadata_merger = Merge::Referential::MetadatasMerger.new new, referential
                        metadata_merger.merge
                    Severity: Minor
                    Found in app/models/merge/referential/legacy.rb - About 7 hrs to fix

                      Method new_alt_calendar has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def new_alt_calendar(options = {}, &block)
                          raise(ArgumentError, "No year given")  unless options.has_key?(:year)
                          raise(ArgumentError, "No month given") unless options.has_key?(:month)
                      
                          block                        ||= Proc.new {|d| nil}
                      Severity: Minor
                      Found in app/helpers/time_tables_helper.rb - About 7 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language