Sign upLogin

agorlov/lipid

View on GitHub
Star
src/Cookie/CookieStd.php

Summary

Maintainability
A
50 mins
Test Coverage

exists accesses the super-global variable $_COOKIE.
Open

    public function exists($name): bool
    {
        return array_key_exists($name, $_COOKIE);
    }
Severity: Minor
Found in src/Cookie/CookieStd.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

get accesses the super-global variable $_COOKIE.
Open

    public function get($name) : string
    {
        if ($this->exists($name)) {
            return $_COOKIE[$name];
        } else {
Severity: Minor
Found in src/Cookie/CookieStd.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method set has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $name,
        $value = "",
        int $expire = 0,
        string $path = "",
        string $domain = "",
Severity: Major
Found in src/Cookie/CookieStd.php - About 50 mins to fix

    The method set has a boolean flag argument $httponly, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $httponly = false
    Severity: Minor
    Found in src/Cookie/CookieStd.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method set has a boolean flag argument $secire, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $secire = false,
    Severity: Minor
    Found in src/Cookie/CookieStd.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    There are no issues that match your filters.

    Category
    Status