ahbeng/NUSMods

Similar blocks of code found in 2 locations. Consider refactoring.

Open

test('findExamClashes should return non-empty object if exams clash', () => {
  const sem: Semester = 1;
  const examClashes = findExamClashes([CS1010S, CS4243 as any, CS3216], sem);
  const examDate = _.get(getModuleSemesterData(CS1010S, sem), 'examDate');
  if (!examDate) throw new Error('Cannot find ExamDate');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    expect(
      reducer(initial, addPlannerModule('2018/2019', 2, { type: 'module', moduleCode: 'CS2030' }))
        .modules,
    ).toEqual({
      0: { id: '0', moduleCode: 'CS1010S', year: '2018/2019', semester: 1, index: 0 },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    expect(
      reducer(initial, addPlannerModule('2018/2019', 1, { type: 'module', moduleCode: 'CS2030' }))
        .modules,
    ).toEqual({
      0: { id: '0', moduleCode: 'CS1010S', year: '2018/2019', semester: 1, index: 0 },

• Read up
  Read up

Function primitive has 82 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public primitive(): PrimitiveContext {
        let _localctx: PrimitiveContext = new PrimitiveContext(this._ctx, this.state);
        this.enterRule(_localctx, 12, NusModsParser.RULE_primitive);
        try {
            this.state = 104;

Function FooterComponent has 82 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export const FooterComponent: React.FC<Props> = (props) => {
  // Try catch because of Chrome crashing on calling toLocaleString with no parameter
  // See https://sentry.io/nusmods/v3/issues/434084130/
  let lastUpdatedText = 'Loading data...';
  if (props.lastUpdatedDate) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('should not open modal when button is disabled', () => {
      const wrapper = shallow(<ModulesSelect {...commonProps} disabled />);
      wrapper.find('button').simulate('click');
      const modal = wrapper.find(Modal).shallow();
      expect(modal.prop('isOpen')).toBe(false);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('should not open modal when button is disabled', () => {
      const wrapper = shallow(<ModulesSelectComponent {...commonProps} disabled />);
      wrapper.find('button').simulate('click');
      const modal = wrapper.find(Modal).shallow();
      expect(modal.prop('isOpen')).toBe(false);

• Read up
  Read up

Function PlannerSettingsComponent has 81 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export const PlannerSettingsComponent: React.FC<Props> = (props) => {
  const matriculationLabels = getYearLabels(MIN_YEARS, MAX_YEARS).reverse();
  const graduationLabels = getYearLabels(0, GRADUATE_IN);

  return (

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (showCPExTab) {
      expect(screen.getAllByRole('link').map((elem) => elem.textContent)).toMatchInlineSnapshot(`
        [
          "Today",
          "Timetable",

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (showCPExTab) {
      expect(screen.getAllByRole('link').map((elem) => elem.textContent)).toMatchInlineSnapshot(`
        [
          "Today",
          "Timetable",

• Read up
  Read up

File ReportError.tsx has 298 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { FC, FormEventHandler, memo, useCallback, useState } from 'react';
import { castArray, groupBy } from 'lodash';
import classnames from 'classnames';
import produce from 'immer';
import axios from 'axios';

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const planner: PlannerState = {
      ...defaultState,
      maxYear: '2017/2018',
      minYear: '2017/2018',
      modules: {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const planner: PlannerState = {
      ...defaultState,
      minYear: '2016/2017',
      maxYear: '2016/2017',
      modules: {

• Read up
  Read up

Function CustomModuleFormComponent has 77 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export const CustomModuleFormComponent: React.FC<Props> = (props) => {
  // We use an uncontrolled form here because we don't want to update the
  // module title and MCs live
  const inputModuleCredit = React.createRef<HTMLInputElement>();
  const inputTitle = React.createRef<HTMLInputElement>();

Function settings has 77 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function settings(state: SettingsState = defaultSettingsState, action: Actions): SettingsState {
  switch (action.type) {
    case SELECT_NEW_STUDENT:
      return {
        ...state,

Similar blocks of code found in 4 locations. Consider refactoring.

Open

          {member.linkedin && (
            <div className="col-sm-1 col">
              <Tooltip content="Linkedin profile" touch="hold">
                <ExternalLink
                  href={`https://www.linkedin.com/in/${member.linkedin}`}

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

          {member.twitter && (
            <div className="col-sm-1 col">
              <Tooltip content="Twitter profile" touch="hold">
                <ExternalLink
                  href={`https://www.twitter.com/${member.twitter}`}

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

          {member.facebook && (
            <div className="col-sm-1 col">
              <Tooltip content="Facebook profile" touch="hold">
                <ExternalLink
                  href={`https://www.facebook.com/${member.facebook}`}

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

          {member.github && (
            <div className="col-sm-1 col">
              <Tooltip content="GitHub profile" touch="hold">
                <ExternalLink
                  href={`https://www.github.com/${member.github}`}

• Read up
  Read up

Function cohort_years has 75 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public cohort_years(): Cohort_yearsContext {
        let _localctx: Cohort_yearsContext = new Cohort_yearsContext(this._ctx, this.state);
        this.enterRule(_localctx, 24, NusModsParser.RULE_cohort_years);
        let _la: number;
        try {