ahbeng/NUSMods

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            {
            this.state = 196;
            this.match(NusModsParser.COURSES);
            this.state = 198;
            this._errHandler.sync(this);

• Read up
  Read up

Function MpeContainer has 123 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const MpeContainer: React.FC = () => {
  const [isGettingSSOLink, setIsGettingSSOLink] = useState(false);
  const [isModalOpen, setIsModalOpen] = useState(false);
  const [isLoggedIn, setIsLoggedIn] = useState(getLoginState(useLocation(), useHistory()));

Similar blocks of code found in 2 locations. Consider refactoring.

Open

function generateAndBranch(modules: PrereqTree[]) {
  const children: PrereqTree[] = R.uniq(modules);
  // Simplifying the expression
  if (children.length === 1) {
    return children[0];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

function generateOrBranch(modules: PrereqTree[]) {
  const children: PrereqTree[] = R.uniq(modules);
  // Simplifying the expression:
  if (children.length === 1) {
    return children[0];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('should open modal and downshift when clicked', () => {
      const wrapper = shallow(<ModulesSelect {...commonProps} />);
      wrapper.find('button').simulate('click');
      const modal = wrapper.find(Modal);
      const downshift = wrapper.find(Downshift);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  test('show many results if the search only returns venues', () => {
    const { getByRole, getAllByRole } = make({
      venueBank: { venueList: range(100).map((n) => `Venue ${n}`) },
    });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('should open modal and downshift when clicked', () => {
      const wrapper = shallow(<ModulesSelectComponent {...commonProps} />);
      wrapper.find('button').simulate('click');
      const modal = wrapper.find(Modal);
      const downshift = wrapper.find(Downshift);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  test('show many results if the search only returns modules', () => {
    const { getByRole, getAllByRole } = make({
      venueBank: { venueList: range(100).map((n) => `Venue ${n}`) },
    });

• Read up
  Read up

Function KeyboardShortcuts has 114 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const KeyboardShortcuts: React.FC = () => {
  const [helpShown, setHelpShown] = useState(false);
  const closeModal = useCallback(() => setHelpShown(false), []);

  const store = useStore<State>();

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  test('should throw on unknown error', async () => {
    mockedAxios.post.mockResolvedValue(
      mockResponse({ code: '20000', msg: 'The server is on fire', data: [] }),
    );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  test('should throw auth error', async () => {
    mockedAxios.post.mockResolvedValue(
      mockResponse({ code: '10000', msg: 'Incorrect user key', data: [] }),
    );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  test('should throw not found error', async () => {
    mockedAxios.post.mockResolvedValue(
      mockResponse({ code: '10001', msg: 'Record not found', data: [] }),
    );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    expect(reducer(initial, movePlannerModule('2', '2018/2019', 2, 0)).modules).toEqual({
      0: { id: '0', moduleCode: 'CS1010S', year: '2018/2019', semester: 1, index: 0 },
      1: { id: '1', moduleCode: 'CS2030', year: '2018/2019', semester: 2, index: 1 },
      2: { id: '2', moduleCode: 'CS2105', year: '2018/2019', semester: 2, index: 0 },
    });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    expect(reducer(initial, movePlannerModule('0', '2017/2018', 2, 0)).modules).toEqual({
      0: { id: '0', moduleCode: 'CS1010S', year: '2017/2018', semester: 2, index: 0 },
      1: { id: '1', moduleCode: 'CS2030', year: '2018/2019', semester: 2, index: 0 },
      2: { id: '2', moduleCode: 'CS2105', year: '2018/2019', semester: 2, index: 1 },
    });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    expect(reducer(initial, movePlannerModule('0', '2018/2019', 2, 1)).modules).toEqual({
      0: { id: '0', moduleCode: 'CS1010S', year: '2018/2019', semester: 2, index: 1 },
      1: { id: '1', moduleCode: 'CS2030', year: '2018/2019', semester: 2, index: 0 },
      2: { id: '2', moduleCode: 'CS2105', year: '2018/2019', semester: 2, index: 2 },
    });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function validateLesson(lesson: TimetableLesson, logger: Logger = rootLogger) {
  const result = lessonSchema.validate(lesson, {
    presence: 'required',
    allowUnknown: true,
    // Don't abort early so we can log all errors

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function validateExam(exam: ModuleExam, logger: Logger = rootLogger) {
  const result = examSchema.validate(exam, {
    presence: 'required',
    allowUnknown: true,
    // Don't abort early so we can log all errors

• Read up
  Read up

Function scraper has 101 lines of code (exceeds 25 allowed). Consider refactoring.

Open

async function scraper() {
  const getDepartmentsResponse = await axios.post<ApiResponse<GetDepartmentsResponseData[]>>(
    `${baseUrl}/config/get-acadorg`,
    {
      eff_status: 'A',

Function TimetableModulesTableComponent has 100 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export const TimetableModulesTableComponent: React.FC<Props> = (props) => {
  const renderModuleActions = (module: ModuleWithColor) => {
    const hideBtnLabel = `${module.hiddenInTimetable ? 'Show' : 'Hide'} ${module.moduleCode}`;
    const removeBtnLabel = `Remove ${module.moduleCode} from timetable`;
    const { semester } = props;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

describe(SET_PLANNER_MAX_YEAR, () => {
  test('should set max year', () => {
    expect(reducer(defaultState, setPlannerMaxYear('2020/2021'))).toEqual({
      ...defaultState,
      minYear: '2017/2018',

• Read up
  Read up