airbnb/caravel

View on GitHub

Showing 2,441 of 6,157 total issues

Function transformProps has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function transformProps(chartProps: ChartProps): WordCloudProps {
  const { width, height, formData, queriesData } = chartProps;
  const {
    colorScheme,
    metric,

    Function formatValueHandler has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const formatValueHandler = (
      value: DiffItemType,
      key: string,
      controlsMap: ControlMap,
    ): string | number => {
    Severity: Minor
    Found in superset-frontend/src/components/AlteredSliceTag/index.tsx - About 1 hr to fix

      Function useFilterFocusHighlightStyles has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const useFilterFocusHighlightStyles = (chartId: number) => {
        const theme = useTheme();
      
        const nativeFilters = useSelector((state: RootState) => state.nativeFilters);
        const dashboardState = useSelector(

        Function CrossFiltersVerticalCollapse has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const CrossFiltersVerticalCollapse = (props: {
          crossFilters: CrossFilterIndicator[];
        }) => {
          const { crossFilters } = props;
          const theme = useTheme();

          Function parseResponse has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export default async function parseResponse<T extends ParseMethod = 'json'>(
            apiPromise: Promise<Response>,
            parseMethod?: T,
          ) {
            type ReturnType = T extends 'raw' | null

            Function normalizeOrderBy has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export default function normalizeOrderBy(
              queryObject: QueryObject,
            ): QueryObject {
              if (Array.isArray(queryObject.orderby) && queryObject.orderby.length > 0) {
                // ensure a valid orderby clause

              Function fetchTimeRange has 44 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export const fetchTimeRange = async (
                timeRange: string,
                columnPlaceholder = 'col',
                shifts?: string[],
              ) => {

                Function constructor has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                  constructor(adhocFilter) {
                    this.expressionType = adhocFilter.expressionType || ExpressionTypes.Simple;
                    if (this.expressionType === ExpressionTypes.Simple) {
                      this.subject = adhocFilter.subject;
                      this.operator = adhocFilter.operator?.toUpperCase();

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function colorFromBounds has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                function colorFromBounds(value, bounds, colorBounds = ACCESSIBLE_COLOR_BOUNDS) {
                  if (bounds) {
                    const [min, max] = bounds;
                    const [minColor, maxColor] = colorBounds;
                    if (min !== null && max !== null) {
                Severity: Minor
                Found in superset-frontend/src/visualizations/TimeTable/TimeTable.jsx - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getSimpleSQLExpression has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                export const getSimpleSQLExpression = (subject, operator, comparator) => {
                  const isMulti =
                    [...MULTI_OPERATORS]
                      .map(op => OPERATOR_ENUM_TO_OPERATOR_TYPE[op].operation)
                      .indexOf(operator) >= 0;
                Severity: Minor
                Found in superset-frontend/src/explore/exploreUtils/index.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function updateDashboardLabelsColor has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                export const updateDashboardLabelsColor = () => async (dispatch, getState) => {
                  const {
                    dashboardInfo: { id, metadata },
                  } = getState();
                  const categoricalSchemes = getCategoricalSchemeRegistry();
                Severity: Minor
                Found in superset-frontend/src/dashboard/actions/dashboardState.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function render has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                  render() {
                    const {
                      children,
                      adjustableWidth,
                      adjustableHeight,

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function __init__ has 14 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def __init__(  # pylint: disable=too-many-arguments
                Severity: Major
                Found in superset/async_events/cache_backend.py - About 1 hr to fix

                  Function upgrade has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def upgrade():
                      bind = op.get_bind()
                      session = db.Session(bind=bind)
                  
                      for datasource in session.query(SqlaTable):

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function send has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def send(self) -> None:
                          global_logs_context = getattr(g, "logs_context", {}) or {}
                          try:
                              client = get_slack_client()
                              title = self._content.name
                  Severity: Minor
                  Found in superset/reports/notifications/slackv2.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function handle_api_exception has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def handle_api_exception(
                      f: Callable[..., FlaskResponse],
                  ) -> Callable[..., FlaskResponse]:
                      """
                      A decorator to catch superset exceptions. Use it after the @api decorator above
                  Severity: Minor
                  Found in superset/views/error_handling.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _normalize_prequery_result_type has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def _normalize_prequery_result_type(
                          self,
                          row: pd.Series,
                          dimension: str,
                          columns_by_name: dict[str, "TableColumn"],
                  Severity: Minor
                  Found in superset/models/helpers.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function base_json_conv has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def base_json_conv(obj: Any) -> Any:
                      """
                      Tries to convert additional types to JSON compatible forms.
                  
                      :param obj: The serializable object
                  Severity: Minor
                  Found in superset/utils/json.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function send_email_smtp has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def send_email_smtp(  # pylint: disable=invalid-name,too-many-arguments,too-many-locals
                      to: str,
                      subject: str,
                      html_content: str,
                      config: dict[str, Any],
                  Severity: Minor
                  Found in superset/utils/core.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function normalize_dttm_col has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def normalize_dttm_col(
                      df: pd.DataFrame,
                      dttm_cols: tuple[DateColumn, ...] = tuple(),
                  ) -> None:
                      for _col in dttm_cols:
                  Severity: Minor
                  Found in superset/utils/core.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language