Sign upLogin

albarji/proxTV

View on GitHub
Star

Showing 27 of 27 total issues

File __init__.py has 464 lines of code (exceeds 250 allowed). Consider refactoring.
Open

r"""**proxTV** is a toolbox implementing blazing fast implementations of Total Variation proximity operators.

The library provides efficient solvers for the following Total Variation proximity problems:

**Standard (l1) Total Variation on a 1-dimensional signal**
Severity: Minor
Found in prox_tv/__init__.py - About 7 hrs to fix

    Cyclomatic complexity is too high in function tvgen. (7)
    Open

    def tvgen(x, ws, ds, ps, n_threads=1, max_iters=0):
    r"""General TV proximal operator for multidimensional signals

    Specifically, this optimizes the following program:
    Severity: Minor
    Found in prox_tv/__init__.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in function test_tvp_1d. (7)
    Open

    def test_tvp_1d():
    Severity: Minor
    Found in prox_tv/prox_tv_test.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    W1 = 0.01 * np.cumsum(np.ones((X.shape[0]-1, X.shape[1])), 1)
    Severity: Major
    Found in prox_tv/demos/demo_filter_image_weighted.py and 1 other location - About 1 hr to fix
    prox_tv/demos/demo_filter_image_weighted.py on lines 45..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    W1 = 0.004 * np.cumsum(np.ones((X.shape[0]-1, X.shape[1])), 1)
    Severity: Major
    Found in prox_tv/demos/demo_filter_image_weighted.py and 1 other location - About 1 hr to fix
    prox_tv/demos/demo_filter_image_weighted.py on lines 19..19

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    W2 = 0.004 * np.cumsum(np.ones((X.shape[0], X.shape[1]-1)), 0)
    Severity: Major
    Found in prox_tv/demos/demo_filter_image_weighted.py and 1 other location - About 1 hr to fix
    prox_tv/demos/demo_filter_image_weighted.py on lines 33..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    W2 = 0.01 * np.cumsum(np.ones((X.shape[0], X.shape[1]-1)), 0)
    Severity: Major
    Found in prox_tv/demos/demo_filter_image_weighted.py and 1 other location - About 1 hr to fix
    prox_tv/demos/demo_filter_image_weighted.py on lines 46..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def _yang_tv2d(x, w, y, max_iters, info, **kwargs):
    """Yang's method for 2D TV proximity"""
    _call(lib.Yang2_TV, x.shape[0], x.shape[1], x, w, y, max_iters, info)
    Severity: Major
    Found in prox_tv/__init__.py and 1 other location - About 1 hr to fix
    prox_tv/__init__.py on lines 423..426

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def _kolmogorov_tv2d(x, w, y, max_iters, info, **kwargs):
    """Kolmogorov's method for 2D TV proximity"""
    _call(lib.Kolmogorov2_TV, x.shape[0], x.shape[1], x, w, y, max_iters, 
              info)
    Severity: Major
    Found in prox_tv/__init__.py and 1 other location - About 1 hr to fix
    prox_tv/__init__.py on lines 409..411

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function tvp_2d has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def tvp_2d(x, w_col, w_row, p_col, p_row, n_threads=1, max_iters=0):
    Severity: Major
    Found in prox_tv/__init__.py - About 50 mins to fix

      Function tvgen has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def tvgen(x, ws, ds, ps, n_threads=1, max_iters=0):
      Severity: Minor
      Found in prox_tv/__init__.py - About 45 mins to fix

        Function _chambollepock_tv2d has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _chambollepock_tv2d(x, w, y, max_iters, info, **kwargs):
        Severity: Minor
        Found in prox_tv/__init__.py - About 45 mins to fix

          Function _chambollepockacc_tv2d has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _chambollepockacc_tv2d(x, w, y, max_iters, info, **kwargs):
          Severity: Minor
          Found in prox_tv/__init__.py - About 45 mins to fix

            Function _dr_tv2d has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def _dr_tv2d(x, w, y, max_iters, info, **kwargs):
            Severity: Minor
            Found in prox_tv/__init__.py - About 45 mins to fix

              Function _pd_tv2d has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def _pd_tv2d(x, w, y, max_iters, info, **kwargs):
              Severity: Minor
              Found in prox_tv/__init__.py - About 45 mins to fix

                Function _kolmogorov_tv2d has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def _kolmogorov_tv2d(x, w, y, max_iters, info, **kwargs):
                Severity: Minor
                Found in prox_tv/__init__.py - About 45 mins to fix

                  Function _condat_tv2d has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def _condat_tv2d(x, w, y, max_iters, info, **kwargs):
                  Severity: Minor
                  Found in prox_tv/__init__.py - About 45 mins to fix

                    Function _condatchambollepock_tv2d has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def _condatchambollepock_tv2d(x, w, y, max_iters, info, **kwargs):
                    Severity: Minor
                    Found in prox_tv/__init__.py - About 45 mins to fix

                      Function _yang_tv2d has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      def _yang_tv2d(x, w, y, max_iters, info, **kwargs):
                      Severity: Minor
                      Found in prox_tv/__init__.py - About 45 mins to fix

                        Function tv1w_2d has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        def tv1w_2d(x, w_col, w_row, max_iters=0, n_threads=1):
                        Severity: Minor
                        Found in prox_tv/__init__.py - About 35 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language