Sign upLogin

albarji/proxTV

View on GitHub
Star

Showing 27 of 27 total issues

Function tvp_1d has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def tvp_1d(x, w, p, method='gpfw', max_iters=0):
Severity: Minor
Found in prox_tv/__init__.py - About 35 mins to fix

    Function tv1_2d has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def tv1_2d(x, w, n_threads=1, max_iters=0, method='dr'):
    Severity: Minor
    Found in prox_tv/__init__.py - About 35 mins to fix

      Function tv1w_2d has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def tv1w_2d(x, w_col, w_row, max_iters=0, n_threads=1):
      Severity: Minor
      Found in prox_tv/__init__.py - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        def _pg_tv2(x, w, y, info):
    """Projected Gradient method for TV2 proximity"""
    _call(lib.PG_TV2, x, w, y, info, np.size(x))
        Severity: Minor
        Found in prox_tv/__init__.py and 1 other location - About 30 mins to fix
        prox_tv/__init__.py on lines 299..301

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        def _ms_tv2(x, w, y, info):
    """More-Sorensen method for TV2 proximity"""
    _call(lib.more_TV2, x, w, y, info, np.size(x))
        Severity: Minor
        Found in prox_tv/__init__.py and 1 other location - About 30 mins to fix
        prox_tv/__init__.py on lines 303..305

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function test_tvp_1d has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def test_tvp_1d():
    """Test that all 1D-lp-TV methods produce equivalent results"""
    # Some of these methods are kind of unstable, so we ensure only that most
    # of the times the results are similar
    methods = ('gp', 'fw', 'gpfw')
        Severity: Minor
        Found in prox_tv/prox_tv_test.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        TODO found
        Open

            # TODO: issues in osx with this test
        Severity: Minor
        Found in prox_tv/prox_tv_test.py by fixme
        Severity
        Category
        Status
        Source
        Language