Sign upLogin

alexkappa/terraform-provider-auth0

View on GitHub
Star
auth0/resource_auth0_guardian.go

Summary

Maintainability
B
6 hrs
Test Coverage
B
84%

Function newGuardian has 91 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func newGuardian() *schema.Resource {
    return &schema.Resource{

        Create: createGuardian,
        Read:   readGuardian,
Severity: Major
Found in auth0/resource_auth0_guardian.go - About 2 hrs to fix

    Function readGuardian has 59 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func readGuardian(d *schema.ResourceData, m interface{}) error {
    api := m.(*management.Management)
    mt, err := api.Guardian.MultiFactor.Phone.MessageTypes()
    if err != nil {
        return err
    Severity: Minor
    Found in auth0/resource_auth0_guardian.go - About 1 hr to fix

      Function readGuardian has 8 return statements (exceeds 4 allowed).
      Open

      func readGuardian(d *schema.ResourceData, m interface{}) error {
    api := m.(*management.Management)
    mt, err := api.Guardian.MultiFactor.Phone.MessageTypes()
    if err != nil {
        return err
      Severity: Major
      Found in auth0/resource_auth0_guardian.go - About 50 mins to fix

        Function readGuardian has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func readGuardian(d *schema.ResourceData, m interface{}) error {
    api := m.(*management.Management)
    mt, err := api.Guardian.MultiFactor.Phone.MessageTypes()
    if err != nil {
        return err
        Severity: Minor
        Found in auth0/resource_auth0_guardian.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func updateEmailFactor(d *schema.ResourceData, api *management.Management) error {
    if changed := d.HasChange("email"); changed {
        enabled := d.Get("email").(bool)
        return api.Guardian.MultiFactor.Email.Enable(enabled)
    }
        Severity: Minor
        Found in auth0/resource_auth0_guardian.go and 1 other location - About 30 mins to fix
        auth0/resource_auth0_guardian.go on lines 174..180

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func updateOTPFactor(d *schema.ResourceData, api *management.Management) error {
    if changed := d.HasChange("otp"); changed {
        enabled := d.Get("otp").(bool)
        return api.Guardian.MultiFactor.OTP.Enable(enabled)
    }
        Severity: Minor
        Found in auth0/resource_auth0_guardian.go and 1 other location - About 30 mins to fix
        auth0/resource_auth0_guardian.go on lines 166..172

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status