alexkappa/terraform-provider-auth0

View on GitHub
auth0/resource_auth0_organization.go

Summary

Maintainability
A
3 hrs
Test Coverage
B
86%

Function newOrganization has 66 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func newOrganization() *schema.Resource {
    return &schema.Resource{

        Create: createOrganization,
        Read:   readOrganization,
Severity: Minor
Found in auth0/resource_auth0_organization.go - About 1 hr to fix

    Function readOrganization has 5 return statements (exceeds 4 allowed).
    Open

    func readOrganization(d *schema.ResourceData, m interface{}) error {
        api := m.(*management.Management)
        o, err := api.Organization.Read(d.Id())
        if err != nil {
            if mErr, ok := err.(management.Error); ok {
    Severity: Major
    Found in auth0/resource_auth0_organization.go - About 35 mins to fix

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func deleteOrganization(d *schema.ResourceData, m interface{}) error {
          api := m.(*management.Management)
          err := api.Organization.Delete(d.Id())
          if err != nil {
              if mErr, ok := err.(management.Error); ok {
      Severity: Major
      Found in auth0/resource_auth0_organization.go and 8 other locations - About 1 hr to fix
      auth0/resource_auth0_client.go on lines 668..680
      auth0/resource_auth0_connection.go on lines 805..817
      auth0/resource_auth0_custom_domain.go on lines 109..121
      auth0/resource_auth0_log_stream.go on lines 239..251
      auth0/resource_auth0_resource_server.go on lines 176..188
      auth0/resource_auth0_role.go on lines 138..150
      auth0/resource_auth0_rule_config.go on lines 77..89
      auth0/resource_auth0_user.go on lines 217..229

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status