Sign upLogin

alexkappa/terraform-provider-auth0

View on GitHub
Star
auth0/resource_auth0_resource_server.go

Summary

Maintainability
B
5 hrs
Test Coverage
B
82%

Function newResourceServer has 97 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func newResourceServer() *schema.Resource {
    return &schema.Resource{

        Create: createResourceServer,
        Read:   readResourceServer,
Severity: Major
Found in auth0/resource_auth0_resource_server.go - About 2 hrs to fix

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    func deleteResourceServer(d *schema.ResourceData, m interface{}) error {
    api := m.(*management.Management)
    err := api.ResourceServer.Delete(d.Id())
    if err != nil {
        if mErr, ok := err.(management.Error); ok {
    Severity: Major
    Found in auth0/resource_auth0_resource_server.go and 8 other locations - About 1 hr to fix
    auth0/resource_auth0_client.go on lines 668..680
    auth0/resource_auth0_connection.go on lines 805..817
    auth0/resource_auth0_custom_domain.go on lines 109..121
    auth0/resource_auth0_log_stream.go on lines 239..251
    auth0/resource_auth0_organization.go on lines 203..215
    auth0/resource_auth0_role.go on lines 138..150
    auth0/resource_auth0_rule_config.go on lines 77..89
    auth0/resource_auth0_user.go on lines 217..229

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 141.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

    func createResourceServer(d *schema.ResourceData, m interface{}) error {
    s := expandResourceServer(d)
    api := m.(*management.Management)
    if err := api.ResourceServer.Create(s); err != nil {
        return err
    Severity: Major
    Found in auth0/resource_auth0_resource_server.go and 6 other locations - About 50 mins to fix
    auth0/resource_auth0_client.go on lines 590..598
    auth0/resource_auth0_client_grant.go on lines 43..51
    auth0/resource_auth0_connection.go on lines 761..769
    auth0/resource_auth0_custom_domain.go on lines 71..79
    auth0/resource_auth0_email.go on lines 97..105
    auth0/resource_auth0_rule.go on lines 53..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 121.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func updateResourceServer(d *schema.ResourceData, m interface{}) error {
    s := expandResourceServer(d)
    s.Identifier = nil
    api := m.(*management.Management)
    err := api.ResourceServer.Update(d.Id(), s)
    Severity: Minor
    Found in auth0/resource_auth0_resource_server.go and 1 other location - About 45 mins to fix
    auth0/resource_auth0_rule_config.go on lines 66..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status