Sign upLogin

alexkappa/terraform-provider-auth0

View on GitHub
Star

Showing 62 of 69 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func expandConnectionOptionsLinkedin(d ResourceData) *management.ConnectionOptionsLinkedin {

    o := &management.ConnectionOptionsLinkedin{
        ClientID:           String(d, "client_id"),
        ClientSecret:       String(d, "client_secret"),
Severity: Major
Found in auth0/structure_auth0_connection.go and 2 other locations - About 45 mins to fix
auth0/structure_auth0_connection.go on lines 547..560
auth0/structure_auth0_connection.go on lines 562..575

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func updateRuleConfig(d *schema.ResourceData, m interface{}) error {
    r := buildRuleConfig(d)
    r.Key = nil
    api := m.(*management.Management)
    err := api.RuleConfig.Upsert(d.Id(), r)
Severity: Minor
Found in auth0/resource_auth0_rule_config.go and 1 other location - About 45 mins to fix
auth0/resource_auth0_resource_server.go on lines 165..174

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func expandConnectionOptionsSalesforce(d ResourceData) *management.ConnectionOptionsSalesforce {

    o := &management.ConnectionOptionsSalesforce{
        ClientID:           String(d, "client_id"),
        ClientSecret:       String(d, "client_secret"),
Severity: Major
Found in auth0/structure_auth0_connection.go and 2 other locations - About 45 mins to fix
auth0/structure_auth0_connection.go on lines 532..545
auth0/structure_auth0_connection.go on lines 562..575

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function deployAction has 6 return statements (exceeds 4 allowed).
Open

func deployAction(d *schema.ResourceData, m interface{}) error {

    if d.Get("deploy").(bool) == true {

        api := m.(*management.Management)
Severity: Major
Found in auth0/resource_auth0_action.go - About 40 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func flattenConnectionOptionsLinkedin(o *management.ConnectionOptionsLinkedin) interface{} {
    return map[string]interface{}{
        "client_id":                o.GetClientID(),
        "client_secret":            o.GetClientSecret(),
        "strategy_version":         o.GetStrategyVersion(),
    Severity: Minor
    Found in auth0/structure_auth0_connection.go and 2 other locations - About 40 mins to fix
    auth0/structure_auth0_connection.go on lines 64..73
    auth0/structure_auth0_connection.go on lines 167..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func flattenConnectionOptionsWindowsLive(o *management.ConnectionOptionsWindowsLive) interface{} {
    return map[string]interface{}{
        "client_id":                o.GetClientID(),
        "client_secret":            o.GetClientSecret(),
        "scopes":                   o.Scopes(),
    Severity: Minor
    Found in auth0/structure_auth0_connection.go and 2 other locations - About 40 mins to fix
    auth0/structure_auth0_connection.go on lines 156..165
    auth0/structure_auth0_connection.go on lines 167..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func flattenConnectionOptionsSalesforce(o *management.ConnectionOptionsSalesforce) interface{} {
    return map[string]interface{}{
        "client_id":                o.GetClientID(),
        "client_secret":            o.GetClientSecret(),
        "community_base_url":       o.GetCommunityBaseURL(),
    Severity: Minor
    Found in auth0/structure_auth0_connection.go and 2 other locations - About 40 mins to fix
    auth0/structure_auth0_connection.go on lines 64..73
    auth0/structure_auth0_connection.go on lines 156..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                            "colors": {
                            Type:     schema.TypeList,
                            Optional: true,
                            MaxItems: 1,
                            Elem: &schema.Resource{
    Severity: Minor
    Found in auth0/resource_auth0_tenant.go and 1 other location - About 35 mins to fix
    auth0/resource_auth0_branding.go on lines 22..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                "colors": {
                Type:     schema.TypeList,
                Optional: true,
                MaxItems: 1,
                Elem: &schema.Resource{
    Severity: Minor
    Found in auth0/resource_auth0_branding.go and 1 other location - About 35 mins to fix
    auth0/resource_auth0_tenant.go on lines 216..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function IsURLWithNoFragment has 5 return statements (exceeds 4 allowed).
    Open

    func IsURLWithNoFragment(i interface{}, k string) (warnings []string, errors []error) {

    v, ok := i.(string)
    if !ok {
        errors = append(errors, fmt.Errorf("expected type of %q to be string", k))
    Severity: Major
    Found in auth0/internal/validation/validation.go - About 35 mins to fix

      Function readBranding has 5 return statements (exceeds 4 allowed).
      Open

      func readBranding(d *schema.ResourceData, m interface{}) error {
    api := m.(*management.Management)
    branding, err := api.Branding.Read()
    if err != nil {
        if mErr, ok := err.(management.Error); ok {
      Severity: Major
      Found in auth0/resource_auth0_branding.go - About 35 mins to fix

        Function readOrganization has 5 return statements (exceeds 4 allowed).
        Open

        func readOrganization(d *schema.ResourceData, m interface{}) error {
    api := m.(*management.Management)
    o, err := api.Organization.Read(d.Id())
    if err != nil {
        if mErr, ok := err.(management.Error); ok {
        Severity: Major
        Found in auth0/resource_auth0_organization.go - About 35 mins to fix

          Function readDataClient has 5 return statements (exceeds 4 allowed).
          Open

          func readDataClient(d *schema.ResourceData, m interface{}) error {
    clientId := auth0.StringValue(String(d, "client_id"))
    if clientId != "" {
        d.SetId(clientId)
        return readClient(d, m)
          Severity: Major
          Found in auth0/data_source_auth0_client.go - About 35 mins to fix

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            func updateLogStream(d *schema.ResourceData, m interface{}) error {
    ls := expandLogStream(d)

    api := m.(*management.Management)
    err := api.LogStream.Update(d.Id(), ls)
            Severity: Major
            Found in auth0/resource_auth0_log_stream.go and 4 other locations - About 35 mins to fix
            auth0/resource_auth0_connection.go on lines 795..803
            auth0/resource_auth0_email_template.go on lines 127..135
            auth0/resource_auth0_rule.go on lines 83..91
            auth0/resource_auth0_trigger_binding.go on lines 97..105

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            func updateTriggerBinding(d *schema.ResourceData, m interface{}) error {
    b := expandTriggerBindings(d)
    api := m.(*management.Management)
    err := api.Action.UpdateBindings(d.Id(), b)
    if err != nil {
            Severity: Major
            Found in auth0/resource_auth0_trigger_binding.go and 4 other locations - About 35 mins to fix
            auth0/resource_auth0_connection.go on lines 795..803
            auth0/resource_auth0_email_template.go on lines 127..135
            auth0/resource_auth0_log_stream.go on lines 228..237
            auth0/resource_auth0_rule.go on lines 83..91

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            func updateRule(d *schema.ResourceData, m interface{}) error {
    c := buildRule(d)
    api := m.(*management.Management)
    err := api.Rule.Update(d.Id(), c)
    if err != nil {
            Severity: Major
            Found in auth0/resource_auth0_rule.go and 4 other locations - About 35 mins to fix
            auth0/resource_auth0_connection.go on lines 795..803
            auth0/resource_auth0_email_template.go on lines 127..135
            auth0/resource_auth0_log_stream.go on lines 228..237
            auth0/resource_auth0_trigger_binding.go on lines 97..105

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            func updateEmailTemplate(d *schema.ResourceData, m interface{}) error {
    e := buildEmailTemplate(d)
    api := m.(*management.Management)
    err := api.EmailTemplate.Update(d.Id(), e)
    if err != nil {
            Severity: Major
            Found in auth0/resource_auth0_email_template.go and 4 other locations - About 35 mins to fix
            auth0/resource_auth0_connection.go on lines 795..803
            auth0/resource_auth0_log_stream.go on lines 228..237
            auth0/resource_auth0_rule.go on lines 83..91
            auth0/resource_auth0_trigger_binding.go on lines 97..105

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func expandConnectionOptionsGitHub(d ResourceData) *management.ConnectionOptionsGitHub {

    o := &management.ConnectionOptionsGitHub{
        ClientID:           String(d, "client_id"),
        ClientSecret:       String(d, "client_secret"),
            Severity: Minor
            Found in auth0/structure_auth0_connection.go and 1 other location - About 35 mins to fix
            auth0/structure_auth0_connection.go on lines 502..514

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func expandConnectionOptionsFacebook(d ResourceData) *management.ConnectionOptionsFacebook {

    o := &management.ConnectionOptionsFacebook{
        ClientID:           String(d, "client_id"),
        ClientSecret:       String(d, "client_secret"),
            Severity: Minor
            Found in auth0/structure_auth0_connection.go and 1 other location - About 35 mins to fix
            auth0/structure_auth0_connection.go on lines 381..393

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func updateEmailFactor(d *schema.ResourceData, api *management.Management) error {
    if changed := d.HasChange("email"); changed {
        enabled := d.Get("email").(bool)
        return api.Guardian.MultiFactor.Email.Enable(enabled)
    }
            Severity: Minor
            Found in auth0/resource_auth0_guardian.go and 1 other location - About 30 mins to fix
            auth0/resource_auth0_guardian.go on lines 174..180

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 102.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language