alexpeattie/nitlink

View on GitHub
lib/nitlink/link_collection.rb

Summary

Maintainability
A
0 mins
Test Coverage

Line is too long. [106/80]
Open

      raise ArgumentError.new('relation_type cannot be blank') if (!relation_type || relation_type.empty?)
Severity: Minor
Found in lib/nitlink/link_collection.rb by rubocop

Provide an exception class and message as arguments to raise.
Open

      raise ArgumentError.new('relation_type cannot be blank') if (!relation_type || relation_type.empty?)
Severity: Minor
Found in lib/nitlink/link_collection.rb by rubocop

This cop checks the args passed to fail and raise. For exploded style (default), it recommends passing the exception class and message to raise, rather than construct an instance of the error. It will still allow passing just a message, or the construction of an error with more than one argument.

The exploded style works identically, but with the addition that it will also suggest constructing error objects when the exception is passed multiple arguments.

Example: EnforcedStyle: exploded (default)

# bad
raise StandardError.new("message")

# good
raise StandardError, "message"
fail "message"
raise MyCustomError.new(arg1, arg2, arg3)
raise MyKwArgError.new(key1: val1, key2: val2)

Example: EnforcedStyle: compact

# bad
raise StandardError, "message"
raise RuntimeError, arg1, arg2, arg3

# good
raise StandardError.new("message")
raise MyCustomError.new(arg1, arg2, arg3)
fail "message"

Final newline missing.
Open

end
Severity: Minor
Found in lib/nitlink/link_collection.rb by rubocop

Don't use parentheses around the condition of an if.
Open

      raise ArgumentError.new('relation_type cannot be blank') if (!relation_type || relation_type.empty?)
Severity: Minor
Found in lib/nitlink/link_collection.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Use alias instead of alias_method in a class body.
Open

    alias_method :to_hash, :to_h
Severity: Minor
Found in lib/nitlink/link_collection.rb by rubocop

This cop enforces the use of either #alias or #alias_method depending on configuration. It also flags uses of alias :symbol rather than alias bareword.

Example: EnforcedStyle: prefer_alias (default)

# bad
alias_method :bar, :foo
alias :bar :foo

# good
alias bar foo

Example: EnforcedStyle: preferaliasmethod

# bad
alias :bar :foo
alias bar foo

# good
alias_method :bar, :foo

Missing top-level class documentation comment.
Open

  class LinkCollection < Array
Severity: Minor
Found in lib/nitlink/link_collection.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [101/80]
Open

      indifferent = options.key?(:with_indifferent_access) ? options[:with_indifferent_access] : true
Severity: Minor
Found in lib/nitlink/link_collection.rb by rubocop

There are no issues that match your filters.

Category
Status