Sign upLogin

algolia/algoliasearch-client-ruby

View on GitHub
Star
lib/algolia/insights_client.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method clicked_object_ids_after_search has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def clicked_object_ids_after_search(event_name, index_name,
        object_ids, positions, query_id, opts = {})
Severity: Minor
Found in lib/algolia/insights_client.rb - About 45 mins to fix

    Method converted_object_ids_after_search has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def converted_object_ids_after_search(event_name, index_name,
        object_ids, query_id, opts = {})
    Severity: Minor
    Found in lib/algolia/insights_client.rb - About 35 mins to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            def initialize(insights_config, opts = {})
        @config      = insights_config
        adapter      = opts[:adapter] || Defaults::ADAPTER
        logger       = opts[:logger] || LoggerHelper.create
        requester    = opts[:http_requester] || Defaults::REQUESTER_CLASS.new(adapter, logger)
      Severity: Major
      Found in lib/algolia/insights_client.rb and 3 other locations - About 35 mins to fix
      lib/algolia/analytics_client.rb on lines 13..18
      lib/algolia/personalization_client.rb on lines 11..16
      lib/algolia/recommend_client.rb on lines 18..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status