Sign upLogin

alibaba/kt-connect

View on GitHub
Star

Showing 109 of 109 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if err == nil && len(podList.Items) > 0 && podList.Items[0].Annotations != nil && podList.Items[0].Annotations[util.KtUser] != "" {
        return " (" + podList.Items[0].Annotations[util.KtUser] + ")"
    }
Severity: Minor
Found in pkg/kt/command/general/resource.go and 1 other location - About 35 mins to fix
pkg/kt/command/general/resource.go on lines 251..253

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    for _, name := range r.ConfigMapsToDelete {
        err := cluster.Ins().RemoveConfigMap(name, opt.Get().Global.Namespace)
        if err != nil {
            log.Warn().Err(err).Msgf("Failed to delete config map %s", name)
        } else {
Severity: Major
Found in pkg/kt/command/clean/common.go and 3 other locations - About 35 mins to fix
pkg/kt/command/clean/common.go on lines 65..72
pkg/kt/command/clean/common.go on lines 83..90
pkg/kt/command/clean/common.go on lines 101..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Unset has 5 return statements (exceeds 4 allowed).
Open

func Unset(args []string) error {
    if unsetAll {
        return saveConfig(make(map[string]map[string]string))
    }
    if len(args) < 1 {
Severity: Major
Found in pkg/kt/command/config/reset.go - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if err == nil && len(appList.Items) > 0 && appList.Items[0].Annotations != nil && appList.Items[0].Annotations[util.KtUser] != "" {
        return " (" + appList.Items[0].Annotations[util.KtUser] + ")"
    }
    Severity: Minor
    Found in pkg/kt/command/general/resource.go and 1 other location - About 35 mins to fix
    pkg/kt/command/general/resource.go on lines 247..249

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function Recover has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
    Open

    func Recover(serviceName string) error {
    svc, err := cluster.Ins().GetService(serviceName, opt.Get().Global.Namespace)
    if err != nil {
        log.Error().Err(err).Msgf("Failed to fetch service '%s'", serviceName)
    }
    Severity: Minor
    Found in pkg/kt/command/recover.go - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function LockService has 5 return statements (exceeds 4 allowed).
    Open

    func LockService(serviceName, namespace string, times int) (*coreV1.Service, error) {
    if times > 10 {
        return nil, fmt.Errorf("failed to obtain kt lock of service %s, please try again later", serviceName)
    }
    svc, err := cluster.Ins().GetService(serviceName, namespace)
    Severity: Major
    Found in pkg/kt/command/general/lock.go - About 35 mins to fix

      Function exposeLocalService has 5 return statements (exceeds 4 allowed).
      Open

      func exposeLocalService(serviceName, shadowPodName string, labels, annotations map[string]string) error {

    envs := make(map[string]string)
    _, podName, privateKeyPath, err := cluster.Ins().GetOrCreateShadow(shadowPodName, labels, annotations, envs,
        opt.Get().Preview.Expose, map[int]string{})
      Severity: Major
      Found in pkg/kt/command/preview/expose.go - About 35 mins to fix

        Function getKtRouteRecords has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func getKtRouteRecords(s *Cli) ([]RouteRecord, error) {
    records := []RouteRecord{}

    // run command: netsh interface ipv4 show route store=persistent
    out, _, err := util.RunAndWait(exec.Command("netsh",
        Severity: Minor
        Found in pkg/kt/service/tun/tun_windows.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function fetchTargetRole has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func fetchTargetRole(apps *appV1.DeploymentList, pods *coreV1.PodList) (*appV1.Deployment, *coreV1.Pod, string) {
    if len(apps.Items) > 0 {
        for _, app := range apps.Items {
            if app.Labels != nil {
                if role, ok2 := app.Labels[util.KtRole]; ok2 {
        Severity: Minor
        Found in pkg/kt/command/recover.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language