Showing 109 of 109 total issues
Function execute
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
func execute(method string, url *url.URL, config *restclient.Config, stdin io.Reader, stdout, stderr io.Writer, tty bool) error {
Avoid deeply nested control flow statements. Open
} else if !strings.HasSuffix(l, midDomain) && !strings.HasSuffix(l, fullDomain) {
recordsToKeep = append(recordsToKeep, l)
}
Function combineKubeOpts
has 7 return statements (exceeds 4 allowed). Open
func combineKubeOpts() (err error) {
var config *clientcmdapi.Config
if opt.Get().Global.Kubeconfig != ""{
// if kubeconfig specified, always read from it
_ = os.Setenv(util.EnvKubeConfig, opt.Get().Global.Kubeconfig)
Avoid deeply nested control flow statements. Open
} else if util.IsMacos() {
dnsPort = opt.Get().Connect.DnsPort
}
Function createRouter
has 7 return statements (exceeds 4 allowed). Open
func createRouter(routerPodName string, svcName string, ports map[int]int, labels map[string]string, versionMark string) error {
namespace := opt.Get().Global.Namespace
routerPod, err := cluster.Ins().GetPod(routerPodName, namespace)
if err == nil && routerPod.DeletionTimestamp != nil {
routerPod, err = cluster.Ins().WaitPodTerminate(routerPodName, namespace)
Function AutoMesh
has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring. Open
func AutoMesh(svc *coreV1.Service) error {
// Lock service to avoid conflict, must be first step
svc, err := general.LockService(svc.Name, opt.Get().Global.Namespace, 0)
if err != nil {
return err
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if keepShortDomain {
recordsToKeep = append(recordsToKeep, l)
}
Avoid deeply nested control flow statements. Open
if _, err = strconv.Atoi(upstreamParts[1]); err == nil {
dnsAddresses = append(dnsAddresses, fmt.Sprintf("udp:%s:%s", upstreamDns, upstreamParts[1]))
} else {
dnsAddresses = append(dnsAddresses, fmt.Sprintf("%s:%s:%d", upstreamParts[0], upstreamDns, common.StandardDnsPort))
}
Function SaveProfile
has 6 return statements (exceeds 4 allowed). Open
func SaveProfile(args []string) error {
if len(args) != 1 {
return fmt.Errorf("must specifiy a profile name")
}
profile := profileFile(args[0])
Function Mesh
has 6 return statements (exceeds 4 allowed). Open
func Mesh(resourceName string) error {
ch, err := general.SetupProcess(util.ComponentMesh)
if err != nil {
return err
}
Function Show
has 6 return statements (exceeds 4 allowed). Open
func Show(args []string) error {
if len(args) > 0 {
return fmt.Errorf("parameter '%s' is invalid", args[0])
}
customConfig := loadCustomConfig()
Function parsePort
has 6 return statements (exceeds 4 allowed). Open
func parsePort(args []string) (localPort int, remotePort int, err error) {
if len(args) < 2 {
// port not specified
return -1, -1, nil
} else if count := strings.Count(args[1], ":"); count == 0 {
Function NewForwardCommand
has 6 return statements (exceeds 4 allowed). Open
func NewForwardCommand() *cobra.Command {
cmd := &cobra.Command{
Use: "forward",
Short: "Redirect local port to a service or any remote address",
PreRunE: func(cmd *cobra.Command, args []string) error {
Function GetServiceByResourceName
has 6 return statements (exceeds 4 allowed). Open
func GetServiceByResourceName(resourceName, namespace string) (*coreV1.Service, error) {
resourceType, name, err := ParseResourceName(resourceName)
if err != nil {
return nil, err
}
Function GetDeploymentByResourceName
has 6 return statements (exceeds 4 allowed). Open
func GetDeploymentByResourceName(resourceName, namespace string) (*appV1.Deployment, error) {
resourceType, name, err := ParseResourceName(resourceName)
if err != nil {
return nil, err
}
Similar blocks of code found in 2 locations. Consider refactoring. Open
if strings.HasPrefix(shadowPod.Name, svc.Name + util.MeshPodInfix) && shadowPod.DeletionTimestamp == nil {
log.Info().Msgf("Deleting shadow pod %s", shadowPod.Name)
if err2 := cluster.Ins().RemovePod(shadowPod.Name, shadowPod.Namespace); err2 != nil {
log.Debug().Err(err2).Msgf("Failed to remove pod %s", pod.Name)
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 108.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if strings.HasPrefix(shadowApp.Name, svc.Name + util.MeshPodInfix) {
log.Info().Msgf("Deleting shadow deployment %s", shadowApp.Name)
if err2 := cluster.Ins().RemoveDeployment(shadowApp.Name, shadowApp.Namespace); err2 != nil {
log.Debug().Err(err2).Msgf("Failed to remove deployment %s", shadowApp.Name)
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 108.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function createRouter
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
func createRouter(routerPodName string, svcName string, ports map[int]int, labels map[string]string, versionMark string) error {
Function Forward
has 5 return statements (exceeds 4 allowed). Open
func Forward(args []string) error {
ch, err := general.SetupProcess(util.ComponentForward)
if err != nil {
return err
}
Method Kubernetes.GetKtResources
has 5 return statements (exceeds 4 allowed). Open
func (k *Kubernetes) GetKtResources(namespace string) ([]coreV1.Pod, []coreV1.ConfigMap, []appV1.Deployment, []coreV1.Service, error) {
pods, err := Ins().GetPodsByLabel(map[string]string{util.ControlBy: util.KubernetesToolkit}, namespace)
if err != nil {
return nil, nil, nil, nil, err
}