Sign upLogin

alibaba/kt-connect

View on GitHub
Star
pkg/kt/service/cluster/shadow_pod.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Kubernetes.tryGetExistingShadows has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func (k *Kubernetes) tryGetExistingShadows(resourceMeta *ResourceMeta, sshKeyMeta *SSHkeyMeta) (*coreV1.Pod, *util.SSHGenerator, error) {
    var app *appV1.Deployment
    var pod *coreV1.Pod
    if opt.Get().Global.UseShadowDeployment {
        app2, err := k.GetDeployment(resourceMeta.Name, resourceMeta.Namespace)
Severity: Minor
Found in pkg/kt/service/cluster/shadow_pod.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Kubernetes.tryGetExistingShadows has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (k *Kubernetes) tryGetExistingShadows(resourceMeta *ResourceMeta, sshKeyMeta *SSHkeyMeta) (*coreV1.Pod, *util.SSHGenerator, error) {
    var app *appV1.Deployment
    var pod *coreV1.Pod
    if opt.Get().Global.UseShadowDeployment {
        app2, err := k.GetDeployment(resourceMeta.Name, resourceMeta.Namespace)
Severity: Minor
Found in pkg/kt/service/cluster/shadow_pod.go - About 1 hr to fix

    Method Kubernetes.tryGetExistingShadows has 10 return statements (exceeds 4 allowed).
    Open

    func (k *Kubernetes) tryGetExistingShadows(resourceMeta *ResourceMeta, sshKeyMeta *SSHkeyMeta) (*coreV1.Pod, *util.SSHGenerator, error) {
    var app *appV1.Deployment
    var pod *coreV1.Pod
    if opt.Get().Global.UseShadowDeployment {
        app2, err := k.GetDeployment(resourceMeta.Name, resourceMeta.Namespace)
    Severity: Major
    Found in pkg/kt/service/cluster/shadow_pod.go - About 1 hr to fix

      Method Kubernetes.createAndGetPod has 5 return statements (exceeds 4 allowed).
      Open

      func (k *Kubernetes) createAndGetPod(metaAndSpec *PodMetaAndSpec, sshcm string) (*coreV1.Pod, error) {
    if opt.Get().Global.UseShadowDeployment {
        if err := k.createShadowDeployment(metaAndSpec, sshcm); err != nil {
            return nil, err
        }
      Severity: Major
      Found in pkg/kt/service/cluster/shadow_pod.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status