tests/AlertsTest.php from alientronics/fleetany-alerts

The class AlertsTest has 13 public methods. Consider refactoring AlertsTest to keep number of public methods under 10.
Open

class AlertsTest extends TestCase
{
    use DatabaseTransactions;
    /**
     * Creates the application.

Found in tests/AlertsTest.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Method `testAlertsPostSuccessAfterHours` has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testAlertsPostSuccessAfterHours()
    {
        $emails = [];
        $names = [];
        $emails[] = "admin@alientronics.com.br";

Found in tests/AlertsTest.php - About 1 hr to fix

Avoid unused local variables such as '$alert'.
Open

        $alert = factory('App\Entities\Alerts')->create();

Found in tests/AlertsTest.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$alert'.
Open

        $alert = factory('App\Entities\Alerts')->create();

Found in tests/AlertsTest.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$alert'.
Open

        $alert = factory('App\Entities\Alerts')->create();

Found in tests/AlertsTest.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$alert'.
Open

        $alert = factory('App\Entities\Alerts')->create();

Found in tests/AlertsTest.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$alert'.
Open

        $alert = factory('App\Entities\Alerts')->create();

Found in tests/AlertsTest.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        $this->post('/api/v1/alert', ['api_token' => env('APP_TOKEN'),
                'emails' => json_encode($emails),
                'company_id' => 1,
                'names' => json_encode($names),
                'subject' => 'Teste Assunto Email',

Found in tests/AlertsTest.php and 2 other locations - About 1 hr to fix

Read up
Read up

tests/AlertsTest.php on lines 109..123

tests/AlertsTest.php on lines 162..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

alientronics/fleetany-alerts

Summary

Maintainability

Test Coverage

The class AlertsTest has 13 public methods. Consider refactoring AlertsTest to keep number of public methods under 10. Open

TooManyPublicMethods

Since: 0.1

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Method testAlertsPostSuccessAfterHours has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open

Avoid unused local variables such as '$alert'. Open

UnusedLocalVariable

Since: 0.2

Example

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$alert'. Open

UnusedLocalVariable

Since: 0.2

Example

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$alert'. Open

UnusedLocalVariable

Since: 0.2

Example

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$alert'. Open

UnusedLocalVariable

Since: 0.2

Example

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$alert'. Open

UnusedLocalVariable

Since: 0.2

Example

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Identical blocks of code found in 3 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

There are no issues that match your filters.

Category

Status

The class AlertsTest has 13 public methods. Consider refactoring AlertsTest to keep number of public methods under 10.
Open

Method `testAlertsPostSuccessAfterHours` has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Avoid unused local variables such as '$alert'.
Open

Avoid unused local variables such as '$alert'.
Open

Avoid unused local variables such as '$alert'.
Open

Avoid unused local variables such as '$alert'.
Open

Avoid unused local variables such as '$alert'.
Open

Identical blocks of code found in 3 locations. Consider refactoring.
Open

Identical blocks of code found in 3 locations. Consider refactoring.
Open

Identical blocks of code found in 3 locations. Consider refactoring.
Open