Sign upLogin

ama-team/php-projection-framework

View on GitHub
Star
src/Type/BilinearReader.php

Summary

Maintainability
A
1 hr
Test Coverage

Method getColorsAt has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getColorsAt($face, $u, $v)
    {
        $colors = [];
        $normalizedU = $u * $this->width - 0.5;
        $normalizedV = $v * $this->height - 0.5;
Severity: Minor
Found in src/Type/BilinearReader.php - About 1 hr to fix

    Function getColorsAt has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getColorsAt($face, $u, $v)
    {
        $colors = [];
        $normalizedU = $u * $this->width - 0.5;
        $normalizedV = $v * $this->height - 0.5;
    Severity: Minor
    Found in src/Type/BilinearReader.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid variables with short names like $u. Configured minimum length is 3.
    Open

        private function getColorsAt($face, $u, $v)
    Severity: Minor
    Found in src/Type/BilinearReader.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $y1. Configured minimum length is 3.
    Open

            $y1 = (int) $normalizedV;
    Severity: Minor
    Found in src/Type/BilinearReader.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $v. Configured minimum length is 3.
    Open

        private function getColorsAt($face, $u, $v)
    Severity: Minor
    Found in src/Type/BilinearReader.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $y2. Configured minimum length is 3.
    Open

            $y2 = $y1 + 1;
    Severity: Minor
    Found in src/Type/BilinearReader.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $x1. Configured minimum length is 3.
    Open

            $x1 = (int) $normalizedU;
    Severity: Minor
    Found in src/Type/BilinearReader.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $x2. Configured minimum length is 3.
    Open

            $x2 = $x1 + 1;
    Severity: Minor
    Found in src/Type/BilinearReader.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status