Sign upLogin

amahi/platform

View on GitHub
Star

Showing 112 of 112 total issues

Method update_pin has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def update_pin
        sleep 2 if development?
        @user = User.find(params[:id])
        if(params[:user][:pin].blank? || params[:user][:pin_confirmation].blank?)
            errors = true
Severity: Minor
Found in plugins/010-users/app/controllers/users_controller.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pkginstall has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def pkginstall(pkgs, sha1 = nil)
            if debian? or ubuntu? or mint?
                c = Command.new "DEBIAN_FRONTEND=noninteractive apt-get -y install #{pkgs}"
                c.run_now
            elsif fedora? or centos?
Severity: Minor
Found in lib/platform.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pkguninstall has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def pkguninstall(pkgs)
            if debian? or ubuntu? or mint?
                c = Command.new "DEBIAN_FRONTEND=noninteractive apt-get -y remove #{pkgs}"
                c.run_now
            elsif fedora? or centos?
Severity: Minor
Found in lib/platform.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize_system has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize_system
        username = params[:username]
        pwd = params[:password]
        conf = params[:password_confirmation]
        unless valid_admin_password?(pwd, conf)
Severity: Minor
Found in app/controllers/user_sessions_controller.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setup_router has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def setup_router
        @router = nil
        r = Setting.get_kind('network', 'router_model')
        return @router unless r
        begin
Severity: Minor
Found in app/controllers/application_controller.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_password has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def update_password
        sleep 2 if development?
        @user = User.find(params[:id])
        if(params[:user][:password].blank? || params[:user][:password_confirmation].blank?)
            errors = true
Severity: Minor
Found in plugins/010-users/app/controllers/users_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize
        @file = '/etc/mtab'
        @info = []
        begin
            f = File.open('/etc/mtab')
Severity: Minor
Found in lib/partition_utils.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method service_start_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def service_start_command(name)
            service = service_name(name)
            if fedora? or arch? or centos?
                "/usr/bin/systemctl start #{service}.service"
            elsif ubuntu? and File.exist?(UPSTART_CONF % service)
Severity: Minor
Found in lib/platform.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        def service_stop_command(name)
            service = service_name(name)
            if fedora? or arch? or centos?
                "/usr/bin/systemctl stop #{service}.service"
            elsif ubuntu? and File.exist?(UPSTART_CONF % service)
Severity: Major
Found in lib/platform.rb and 3 other locations - About 45 mins to fix
lib/platform.rb on lines 225..235
lib/platform.rb on lines 251..261
lib/platform.rb on lines 264..274

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def create
        nm = params[:name]
        path = params[:path]
        if nm.nil? or nm.blank? or ((not (valid_name?(nm))) or (nm.size > 32) or (path.size > 64))
            flash.now[:error] = "Bad share name!"
Severity: Minor
Found in app/controllers/share_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method service_enable_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def service_enable_command(name)
            service = service_name(name)
            if fedora? or arch? or centos?
                "/usr/bin/systemctl enable #{service}.service"
            elsif ubuntu? and File.exist?(UPSTART_CONF % service)
Severity: Minor
Found in lib/platform.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method install_webapp has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def install_webapp(installer, source)

        name = webapp_name(installer.url_name)
        path = WEBAPP_PATH % name
Severity: Minor
Found in app/models/app.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method service_stop_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def service_stop_command(name)
            service = service_name(name)
            if fedora? or arch? or centos?
                "/usr/bin/systemctl stop #{service}.service"
            elsif ubuntu? and File.exist?(UPSTART_CONF % service)
Severity: Minor
Found in lib/platform.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        def service_enable_command(name)
            service = service_name(name)
            if fedora? or arch? or centos?
                "/usr/bin/systemctl enable #{service}.service"
            elsif ubuntu? and File.exist?(UPSTART_CONF % service)
Severity: Major
Found in lib/platform.rb and 3 other locations - About 45 mins to fix
lib/platform.rb on lines 225..235
lib/platform.rb on lines 238..248
lib/platform.rb on lines 264..274

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method simple_remote_checkbox has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def simple_remote_checkbox options
        parsed_options = {}
        parsed_options[:checked] = 'checked' if options[:checked]
        parsed_options[:disabled] = 'disabled' if options[:disabled]
Severity: Minor
Found in app/helpers/application_helper.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_pubkey has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def update_pubkey
        sleep 2 if development?
        @user = User.find(params[:id])
        # sleep a little to see the spinner working well
        unless @user
Severity: Minor
Found in plugins/010-users/app/controllers/users_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method valid_address? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def valid_address?(addr)
        return false if addr.nil?
        # NOTE: do not allow aliases to the hda as a blank address
        return false if addr.blank?
        return false unless (addr =~ VALID_ADDRESS)
Severity: Minor
Found in app/controllers/aliases_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        def service_disable_command(name)
            service = service_name(name)
            if fedora? or arch? or centos?
                "/usr/bin/systemctl enable #{service}.service"
            elsif ubuntu? and File.exist?(UPSTART_CONF % service)
Severity: Major
Found in lib/platform.rb and 3 other locations - About 45 mins to fix
lib/platform.rb on lines 225..235
lib/platform.rb on lines 238..248
lib/platform.rb on lines 251..261

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method service_disable_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def service_disable_command(name)
            service = service_name(name)
            if fedora? or arch? or centos?
                "/usr/bin/systemctl enable #{service}.service"
            elsif ubuntu? and File.exist?(UPSTART_CONF % service)
Severity: Minor
Found in lib/platform.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read_lease has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def self.read_lease(file)
        res = []
        return res unless File.exists?(file)
        current = {}
        File.foreach(file) do |line|
Severity: Minor
Found in lib/leases.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language