amahi/platform

View on GitHub

Showing 112 of 112 total issues

Method valid_address? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def valid_address?(addr)
        return false if addr.nil?
        # NOTE: do not allow aliases to the hda as a blank address
        return false if addr.blank?
        return false unless (addr =~ VALID_ADDRESS)
Severity: Minor
Found in app/controllers/aliases_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        def service_enable_command(name)
            service = service_name(name)
            if fedora? or arch? or centos?
                "/usr/bin/systemctl enable #{service}.service"
            elsif ubuntu? and File.exist?(UPSTART_CONF % service)
Severity: Major
Found in lib/platform.rb and 3 other locations - About 45 mins to fix
lib/platform.rb on lines 225..235
lib/platform.rb on lines 238..248
lib/platform.rb on lines 264..274

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def video
        @query = params[:query]
        @page = (params[:page] && params[:page].to_i.abs) || 1
        @rpp = (params[:per_page] && params[:per_page].to_i.abs) || RESULTS_PER_PAGE
        @results = hda_search(@query, EXT_VIDEO, @page, @rpp)
Severity: Major
Found in app/controllers/search_controller.rb and 2 other locations - About 40 mins to fix
app/controllers/search_controller.rb on lines 53..58
app/controllers/search_controller.rb on lines 61..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def images
        @query = params[:query]
        @page = (params[:page] && params[:page].to_i.abs) || 1
        @rpp = (params[:per_page] && params[:per_page].to_i.abs) || RESULTS_PER_PAGE
        @results = hda_search(@query, EXT_IMAGES, @page, @rpp)
Severity: Major
Found in app/controllers/search_controller.rb and 2 other locations - About 40 mins to fix
app/controllers/search_controller.rb on lines 61..66
app/controllers/search_controller.rb on lines 69..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def audio
        @query = params[:query]
        @page = (params[:page] && params[:page].to_i.abs) || 1
        @rpp = (params[:per_page] && params[:per_page].to_i.abs) || RESULTS_PER_PAGE
        @results = hda_search(@query, EXT_AUDIO, @page, @rpp)
Severity: Major
Found in app/controllers/search_controller.rb and 2 other locations - About 40 mins to fix
app/controllers/search_controller.rb on lines 53..58
app/controllers/search_controller.rb on lines 69..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Consider simplifying this complex logical expression.
Open

        if params[:button] && params[:button] == "Web"
            require 'uri'
            redirect_to URI.escape("http://www.google.com/search?q=#{params[:query]}")
        else
            @query = params[:query]
Severity: Major
Found in app/controllers/search_controller.rb - About 40 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def delete
            a = Host.find params[:id]
            a.destroy
            hosts = Host.all
            @net = Setting.get('net')
    Severity: Minor
    Found in app/controllers/hosts_controller.rb and 1 other location - About 40 mins to fix
    app/controllers/aliases_controller.rb on lines 141..149

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def delete
            a = DnsAlias.find params[:id]
            a.destroy
            aliases = DnsAlias.user_visible
            @net = Setting.get('net')
    Severity: Minor
    Found in app/controllers/aliases_controller.rb and 1 other location - About 40 mins to fix
    app/controllers/hosts_controller.rb on lines 153..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def initialize(controller, label, url, parent = nil, advanced = false)
    Severity: Minor
    Found in lib/tab.rb - About 35 mins to fix

      Method download_direct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.download_direct(url)
      
              redirect_limit = 5
      
              while redirect_limit > 0
      Severity: Minor
      Found in lib/downloader.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method toggle_disk_pool_partition has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def toggle_disk_pool_partition
              path = params[:path]
              part = DiskPoolPartition.where(:path=>path).first
              if part
                  # was enabled - disable it by deleting it
      Severity: Minor
      Found in app/controllers/share_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_address has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def update_address
              a = DnsAlias.find(params[:id])
              addr = params[:value].strip
              # FIXME - report errors to the user!
              unless valid_address?(addr)
      Severity: Minor
      Found in app/controllers/aliases_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method locate_cache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def locate_cache(term)
              FileUtils.mkdir_p(SEARCH_CACHE)
              sha1 = Digest::SHA1.hexdigest(term)
              cache = File.join(SEARCH_CACHE, sha1)
              # expire old entries in the cache to prevent accumulation (12 hours, index is 24 hours old)
      Severity: Minor
      Found in app/controllers/search_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return false
      Severity: Major
      Found in app/models/app.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return true
        Severity: Major
        Found in app/controllers/aliases_controller.rb - About 30 mins to fix

          Method update_size has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def update_size
                  sleep 1 if development?
                  begin
                      std_out, status = Open3.capture2e("du -sbL #{@share.path}")
                      size = std_out.split(' ').first
          Severity: Minor
          Found in plugins/020-shares/app/controllers/shares_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method check_availability has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def self.check_availability
                  progress = Rails.cache.read("progress")
                  return true if progress.blank?
                  return true if progress == 999
          
          
          Severity: Minor
          Found in app/models/app.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def initialize(theme={})
                  self.path = theme[:path]
                  self.name = theme[:name]
                  self.headers = theme[:headers].present? ? theme[:headers].map{|h| (h =~ /\.js$/) ? "/#{THEME_ROOT}/#{@theme_name}/#{h}" : h } : []
                  self.gruff = theme[:gruff_theme]
          Severity: Minor
          Found in lib/set_theme.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method download_and_check_sha1 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def self.download_and_check_sha1(url, sha1)
          
                  raise SHA1VerificationFailed, "#{url}, sha1sum provided is empty!" unless sha1
                  TempCache.expire_unused_files
                  FileUtils.mkdir_p(HDA_DOWNLOAD_CACHE)
          Severity: Minor
          Found in lib/downloader.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method update_lease_time has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def update_lease_time
              sleep 2 if development?
              @saved = params[:lease_time].present? && params[:lease_time].to_i > 0 ? Setting.set("lease_time", params[:lease_time], KIND) : false
              render :json => { :status => @saved ? :ok : :not_acceptable }
              system("hda-ctl-hup")
          Severity: Minor
          Found in plugins/050-network/app/controllers/network_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language