Sign upLogin

amatriain/feedbunch

View on GitHub
Star
FeedBunch-app/lib/entry_manager.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method save_new_entries has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def self.save_new_entries(feed, entries, encoding)
    entries.reverse_each do |entry_parsed|

      begin
        guid = entry_parsed.entry_id || entry_parsed.url
Severity: Minor
Found in FeedBunch-app/lib/entry_manager.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method save_new_entries has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.save_new_entries(feed, entries, encoding)
    entries.reverse_each do |entry_parsed|

      begin
        guid = entry_parsed.entry_id || entry_parsed.url
Severity: Minor
Found in FeedBunch-app/lib/entry_manager.rb - About 1 hr to fix

    Method entry_to_hash has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.entry_to_hash(entry, guid)
    # Some feed parser types do not give a "content" attribute to their entries. In
    # this case we default to the entry summary.
    if entry.respond_to? :content
      content = entry.content
    Severity: Minor
    Found in FeedBunch-app/lib/entry_manager.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status